You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/11/23 20:12:55 UTC

Review Request 40608: fixing GEODE-590: CI failure in GMSLocatorRecoveryJUnitTest

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40608/
-----------------------------------------------------------

Review request for geode and Jianxia Chen.


Repository: geode


Description
-------

GMSHealthMonitorJUnitTest sets a system property, gemfire.bind-address, but was not removing it during tearDown.  This affected subsequent tests run in the same JVM on some machines.


Diffs
-----

  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java 697e899394e7dea6031e580be000b5af693c10c8 

Diff: https://reviews.apache.org/r/40608/diff/


Testing
-------


Thanks,

Bruce Schuchardt


Re: Review Request 40608: fixing GEODE-590: CI failure in GMSLocatorRecoveryJUnitTest

Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40608/#review107631
-----------------------------------------------------------

Ship it!


Ship It!

- Jianxia Chen


On Nov. 23, 2015, 7:12 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40608/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 7:12 p.m.)
> 
> 
> Review request for geode and Jianxia Chen.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GMSHealthMonitorJUnitTest sets a system property, gemfire.bind-address, but was not removing it during tearDown.  This affected subsequent tests run in the same JVM on some machines.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java 697e899394e7dea6031e580be000b5af693c10c8 
> 
> Diff: https://reviews.apache.org/r/40608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>