You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Balu Vellanki <bv...@hortonworks.com> on 2015/09/30 04:21:42 UTC

Review Request 38872: In some scenarios, list feed entities shows scheduled Feed entities as submitted

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38872/
-----------------------------------------------------------

Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.


Bugs: FALCON-1339
    https://issues.apache.org/jira/browse/FALCON-1339


Repository: falcon-git


Description
-------

When a feed has no replication and the validity of the feed is in the past, no bundles are created for this feed upon scheduling it. This would cause the status of feed to be incorrectly shown as "SUBMITTED". Solution is to create and submit a one time bundle to perform retention on the feed.


Diffs
-----

  oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java a4b5f35 

Diff: https://reviews.apache.org/r/38872/diff/


Testing
-------

Patch applies cleanly, unit and IT tests pass, performed End2End testing on a single node unsecure setup.


Thanks,

Balu Vellanki


Re: Review Request 38872: In some scenarios, list feed entities shows scheduled Feed entities as submitted

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38872/#review101542
-----------------------------------------------------------

Ship it!


- Venkat Ranganathan


On Sept. 29, 2015, 7:21 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38872/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 7:21 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1339
>     https://issues.apache.org/jira/browse/FALCON-1339
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> When a feed has no replication and the validity of the feed is in the past, no bundles are created for this feed upon scheduling it. This would cause the status of feed to be incorrectly shown as "SUBMITTED". Solution is to create and submit a one time bundle to perform retention on the feed.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java a4b5f35 
> 
> Diff: https://reviews.apache.org/r/38872/diff/
> 
> 
> Testing
> -------
> 
> Patch applies cleanly, unit and IT tests pass, performed End2End testing on a single node unsecure setup.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Re: Review Request 38872: In some scenarios, list feed entities shows scheduled Feed entities as submitted

Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38872/#review101529
-----------------------------------------------------------

Ship it!


Ship It!

- Sowmya Ramesh


On Sept. 30, 2015, 2:21 a.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38872/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 2:21 a.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1339
>     https://issues.apache.org/jira/browse/FALCON-1339
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> When a feed has no replication and the validity of the feed is in the past, no bundles are created for this feed upon scheduling it. This would cause the status of feed to be incorrectly shown as "SUBMITTED". Solution is to create and submit a one time bundle to perform retention on the feed.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java a4b5f35 
> 
> Diff: https://reviews.apache.org/r/38872/diff/
> 
> 
> Testing
> -------
> 
> Patch applies cleanly, unit and IT tests pass, performed End2End testing on a single node unsecure setup.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Re: Review Request 38872: In some scenarios, list feed entities shows scheduled Feed entities as submitted

Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38872/#review101066
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java (line 54)
<https://reviews.apache.org/r/38872/#comment158377>

    This change would ensure there is no null pointer exception at line 61 at feedCluster.getValidity()


- Balu Vellanki


On Sept. 30, 2015, 2:21 a.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38872/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 2:21 a.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1339
>     https://issues.apache.org/jira/browse/FALCON-1339
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> When a feed has no replication and the validity of the feed is in the past, no bundles are created for this feed upon scheduling it. This would cause the status of feed to be incorrectly shown as "SUBMITTED". Solution is to create and submit a one time bundle to perform retention on the feed.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java a4b5f35 
> 
> Diff: https://reviews.apache.org/r/38872/diff/
> 
> 
> Testing
> -------
> 
> Patch applies cleanly, unit and IT tests pass, performed End2End testing on a single node unsecure setup.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Re: Review Request 38872: In some scenarios, list feed entities shows scheduled Feed entities as submitted

Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38872/#review101072
-----------------------------------------------------------

Ship it!


Ship It!

- sandeep samudrala


On Sept. 30, 2015, 2:21 a.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38872/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 2:21 a.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1339
>     https://issues.apache.org/jira/browse/FALCON-1339
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> When a feed has no replication and the validity of the feed is in the past, no bundles are created for this feed upon scheduling it. This would cause the status of feed to be incorrectly shown as "SUBMITTED". Solution is to create and submit a one time bundle to perform retention on the feed.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java a4b5f35 
> 
> Diff: https://reviews.apache.org/r/38872/diff/
> 
> 
> Testing
> -------
> 
> Patch applies cleanly, unit and IT tests pass, performed End2End testing on a single node unsecure setup.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>