You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/11/17 19:39:14 UTC
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5130
to review the following change.
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
[docs] Add krb5-devel to the SLES12 instructions
Change-Id: I9f98443a923edb6687427a5863e969883266bd30
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/5130/1
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions
......................................................................
Patch Set 3: Code-Review+2
I suspect we also need krb5-user and krb5-workstation on SLES12 (maybe your AMI had them preinstalled), but I don't have time to verify that right now.
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5130
to look at the new patch set (#2).
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
[docs] Add krb5-devel to the SLES12 instructions
Change-Id: I9f98443a923edb6687427a5863e969883266bd30
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/5130/2
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5130
to look at the new patch set (#3).
Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions
......................................................................
[docs] Add missing krb deps to the SLES12 and Ubuntu instructions
Change-Id: I9f98443a923edb6687427a5863e969883266bd30
---
M docs/installation.adoc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/5130/3
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
Patch Set 2:
This is still relevant. We discussed it on slack on November 17th around 12:45pm. The conclusion was that we need to add a similar dependency for Ubuntu, but not for rhel. The rhel openssl package already has a transitive dep on krb5-devel.
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
Patch Set 2:
Is this one still relevant?
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
Patch Set 1:
(2 comments)
I bet you need the equivalent of krb5-devel in the other distros too. There's libkrb5-dev on Ubuntu which provides /usr/include/krb5.h, and /usr/include/gssapi as well as a bunch of shared objects.
http://gerrit.cloudera.org:8080/#/c/5130/1/docs/installation.adoc
File docs/installation.adoc:
Line 451: $ sudo zypper install autoconf automake curl cyrus-sasl-devel \
I think Dan resorted this; could you maintain the sort order?
Line 504: sudo zypper install -y autoconf automake curl cyrus-sasl-devel \
Same.
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
Patch Set 2:
> Do you know off-hand what exactly I need to add for Ubuntu? Else I
> don't want this to rot.
libkrb5-dev.
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
Patch Set 1:
(1 comment)
> (2 comments)
>
> I bet you need the equivalent of krb5-devel in the other distros
> too. There's libkrb5-dev on Ubuntu which provides /usr/include/krb5.h,
> and /usr/include/gssapi as well as a bunch of shared objects.
I'm just fixing the SLES12 install docs, I didn't look at the other platforms. AFAIK they're supposed to be complete (looks at Dan).
http://gerrit.cloudera.org:8080/#/c/5130/1/docs/installation.adoc
File docs/installation.adoc:
Line 451: $ sudo zypper install autoconf automake curl cyrus-sasl-devel \
> I think Dan resorted this; could you maintain the sort order?
Oh I didn't even notice, I was just putting it next to openssl. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions
......................................................................
[docs] Add missing krb deps to the SLES12 and Ubuntu instructions
Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Reviewed-on: http://gerrit.cloudera.org:8080/5130
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/installation.adoc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Add krb5-devel to the SLES12 instructions
......................................................................
Patch Set 2:
> This is still relevant. We discussed it on slack on November 17th
> around 12:45pm. The conclusion was that we need to add a similar
> dependency for Ubuntu, but not for rhel. The rhel openssl package
> already has a transitive dep on krb5-devel.
Do you know off-hand what exactly I need to add for Ubuntu? Else I don't want this to rot.
--
To view, visit http://gerrit.cloudera.org:8080/5130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f98443a923edb6687427a5863e969883266bd30
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No