You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/12 08:19:20 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #8541: [Transaction] Fix the Github CI Test

eolivelli commented on a change in pull request #8541:
URL: https://github.com/apache/pulsar/pull/8541#discussion_r521913957



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
##########
@@ -365,7 +365,7 @@ public void txnMessageAckTest() throws Exception {
 
         message = consumer.receive(2, TimeUnit.SECONDS);
         Assert.assertNull(message);
-
+        Thread.sleep(500);

Review comment:
       this is not usually a good fix,
   you should wait until a given condition is met, other wise the test will be only "less flaky"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org