[GitHub] [incubator-superset] villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic
URL: https://github.com/apache/incubator-superset/pull/8098#discussion_r316971799
 
 

 ##########
 File path: superset/db_engine_specs/hive.py
 ##########
 @@ -343,7 +346,7 @@ def select_star(
         latest_partition: bool = True,
         cols: Optional[List[Dict[str, Any]]] = None,
     ) -> str:
-        return BaseEngineSpec.select_star(
+        return super(PrestoEngineSpec, cls).select_star(
 
 Review comment:
   As `HiveEngineSpec` already extends `PrestoEngineSpec`, this wouldn't really be needed. It is my understanding, that the reason for calling `BaseEngineSpec` here is because we specifically don't want to use the default behaviour of `PrestoEngineSpect`, but rather what's defined in `BaseEngineSpec`. Not being familiar with how Hive/Presto works in this case someone with deeper knowledge of their respective intricacies would probably need to check this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org