Re: [PR] [VL] Fall back scan if file scheme is not supported by registered file systems [incubator-gluten]

["wForget (via GitHub)" <gi...@apache.org>]

wForget commented on code in PR #6672:
URL: https://github.com/apache/incubator-gluten/pull/6672#discussion_r1710595764


##########
gluten-core/src/main/scala/org/apache/spark/sql/hive/HiveTableScanExecTransformer.scala:
##########
@@ -76,6 +76,8 @@ case class HiveTableScanExecTransformer(
     Seq.empty
   }
 
+  override def getRootPathsInternal: Seq[String] = Seq.empty

Review Comment:
   Can we use table location as root path? Or add a TODO comment,



##########
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scala:
##########
@@ -54,6 +54,8 @@ case class IcebergScanTransformer(
 
   override def getInputFilePathsInternal: Seq[String] = Seq.empty
 
+  override def getRootPathsInternal: Seq[String] = Seq.empty

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org