[GitHub] [hbase] GeorryHuang commented on a change in pull request #3373: HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r…

[GitBox <gi...@apache.org>]

GeorryHuang commented on a change in pull request #3373:
URL: https://github.com/apache/hbase/pull/3373#discussion_r655369081



##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -268,7 +269,12 @@
               for (int j = 0; j < numMetaReplicas; j++) {
                 RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
                         RegionInfoBuilder.FIRST_META_REGIONINFO, j);
-                ServerName metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+                ServerName metaLocation = null;
+                try {
+                  metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+                } catch (NotAllMetaRegionsOnlineException e) {
+                  //Should ignore this Exception for we don't need to display rit meta region info in UI
+                }

Review comment:
       > In this case, the user is looking at the meta table specifically. Maybe the below `if (metaLocation != null) {...` needs an `else` block that prints a message stating that some region location(s) could not be identified?
   
   Since the user may learn the meta region is in transition state from the transition list in Master status UI， Should we still show any details here?
   
   After I check the current implementation it shows that If a region of user-level table is in transition, it does not be displayed in its table details page. So I think the meta region should be the same.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org