You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/02/23 12:22:43 UTC
[GitHub] [dubbo-go-samples] zhaoyunxing92 opened a new pull request #53: add:metric文档
zhaoyunxing92 opened a new pull request #53:
URL: https://github.com/apache/dubbo-go-samples/pull/53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #53: add:metric文档
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #53:
URL: https://github.com/apache/dubbo-go-samples/pull/53#discussion_r581651311
##########
File path: metric/go-server/docker/docker-compose.yml
##########
@@ -1,9 +1,41 @@
-version: '3'
+version: '3.5'
services:
zookeeper:
- image: zookeeper
+ image: zookeeper:latest
+ container_name: zookeeper
+ networks:
+ - dubbo
ports:
- 2181:2181
- restart: on-failure
-
+ # grafana:
Review comment:
Why comment this part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] beiwei30 merged pull request #53: add:metric文档
Posted by GitBox <gi...@apache.org>.
beiwei30 merged pull request #53:
URL: https://github.com/apache/dubbo-go-samples/pull/53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #53: add:metric文档
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #53:
URL: https://github.com/apache/dubbo-go-samples/pull/53#discussion_r581646900
##########
File path: metric/go-server/cmd/server.go
##########
@@ -31,7 +31,7 @@ import (
hessian "github.com/apache/dubbo-go-hessian2"
"github.com/prometheus/client_golang/prometheus/promhttp"
Review comment:
pls split it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] zhaoyunxing92 commented on a change in pull request #53: add:metric文档
Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 commented on a change in pull request #53:
URL: https://github.com/apache/dubbo-go-samples/pull/53#discussion_r581987527
##########
File path: metric/go-server/docker/docker-compose.yml
##########
@@ -1,9 +1,41 @@
-version: '3'
+version: '3.5'
services:
zookeeper:
- image: zookeeper
+ image: zookeeper:latest
+ container_name: zookeeper
+ networks:
+ - dubbo
ports:
- 2181:2181
- restart: on-failure
-
+ # grafana:
Review comment:
我感觉失败了应该去排查不应该频繁重启
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org