You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/23 10:20:47 UTC
[GitHub] [spark] maropu commented on a change in pull request #29202: [SPARK-32406][SQL] Support reset sql configuration one by one
maropu commented on a change in pull request #29202:
URL: https://github.com/apache/spark/pull/29202#discussion_r459350948
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -245,7 +245,7 @@ statement
| SET TIME ZONE timezone=(STRING | LOCAL) #setTimeZone
| SET TIME ZONE .*? #setTimeZone
| SET .*? #setConfiguration
- | RESET #resetConfiguration
+ | RESET multipartIdentifier? #resetConfiguration
Review comment:
How should we handle a hive session conf in `RESET`, e.g., `hivevar:xxx:yyy`? https://issues.apache.org/jira/browse/SPARK-18086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org