You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/10/21 03:22:43 UTC

[PR] [refactor](minor) Remove unused Partitioner [doris]

Gabriel39 opened a new pull request, #42147:
URL: https://github.com/apache/doris/pull/42147

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425669313

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425544016

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192032 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 5938b1bece44661efe28f9c81f77a272f6b9992d, data reload: false
   
   query1	940	388	396	388
   query2	6285	2152	2027	2027
   query3	8678	191	201	191
   query4	34106	23886	23504	23504
   query5	3579	469	472	469
   query6	274	161	162	161
   query7	4192	293	300	293
   query8	285	233	220	220
   query9	9517	2728	2732	2728
   query10	442	297	284	284
   query11	17974	15332	15239	15239
   query12	155	100	103	100
   query13	1566	427	404	404
   query14	9447	7198	7788	7198
   query15	303	165	174	165
   query16	7477	461	439	439
   query17	1770	620	589	589
   query18	1864	312	311	311
   query19	380	161	162	161
   query20	125	117	115	115
   query21	215	105	107	105
   query22	4672	4674	4430	4430
   query23	34975	34458	34123	34123
   query24	11188	2765	2820	2765
   query25	634	402	415	402
   query26	1338	158	166	158
   query27	2500	281	282	281
   query28	7649	2421	2427	2421
   query29	871	430	428	428
   query30	256	153	153	153
   query31	1038	805	812	805
   query32	103	56	55	55
   query33	768	303	299	299
   query34	924	510	529	510
   query35	909	739	754	739
   query36	1119	937	970	937
   query37	156	84	90	84
   query38	3959	3861	3944	3861
   query39	1482	1434	1399	1399
   query40	254	99	99	99
   query41	49	47	47	47
   query42	126	100	97	97
   query43	535	502	504	502
   query44	1337	820	800	800
   query45	196	164	168	164
   query46	1141	684	713	684
   query47	1956	1805	1855	1805
   query48	412	325	342	325
   query49	907	432	439	432
   query50	810	405	389	389
   query51	7100	7003	6999	6999
   query52	101	90	90	90
   query53	254	181	178	178
   query54	1374	433	427	427
   query55	81	82	78	78
   query56	294	272	279	272
   query57	1304	1160	1125	1125
   query58	247	237	239	237
   query59	3363	3105	3102	3102
   query60	290	287	268	268
   query61	108	101	99	99
   query62	863	678	669	669
   query63	228	188	179	179
   query64	4928	634	612	612
   query65	3291	3200	3206	3200
   query66	1370	304	303	303
   query67	15893	15820	15688	15688
   query68	4409	582	576	576
   query69	474	285	285	285
   query70	1203	1113	1141	1113
   query71	373	271	278	271
   query72	7216	3951	4004	3951
   query73	787	359	357	357
   query74	9982	8974	9049	8974
   query75	3441	2628	2665	2628
   query76	3030	931	873	873
   query77	579	310	299	299
   query78	10579	9722	9710	9710
   query79	1353	615	608	608
   query80	861	482	481	481
   query81	580	246	244	244
   query82	732	147	145	145
   query83	307	136	140	136
   query84	283	71	75	71
   query85	1211	299	283	283
   query86	316	297	270	270
   query87	4464	4246	4434	4246
   query88	2873	2235	2176	2176
   query89	412	289	283	283
   query90	2258	189	188	188
   query91	134	99	98	98
   query92	66	48	48	48
   query93	1091	530	543	530
   query94	1063	294	246	246
   query95	358	249	248	248
   query96	612	287	287	287
   query97	3278	3093	3166	3093
   query98	223	204	196	196
   query99	1615	1314	1307	1307
   Total cold run time: 299090 ms
   Total hot run time: 192032 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425535348

   TeamCity be ut coverage result:
    Function Coverage: 37.48% (9709/25906) 
    Line Coverage: 28.75% (80653/280502)
    Region Coverage: 28.19% (41732/148035)
    Branch Coverage: 24.77% (21215/85654)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/5938b1bece44661efe28f9c81f77a272f6b9992d_5938b1bece44661efe28f9c81f77a272f6b9992d/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425481877

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425549564

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.37 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 5938b1bece44661efe28f9c81f77a272f6b9992d, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.07	0.02	0.03
   query3	0.23	0.06	0.06
   query4	1.65	0.10	0.10
   query5	0.53	0.50	0.50
   query6	1.13	0.73	0.73
   query7	0.02	0.01	0.03
   query8	0.04	0.03	0.03
   query9	0.56	0.51	0.50
   query10	0.56	0.56	0.54
   query11	0.15	0.11	0.11
   query12	0.14	0.11	0.12
   query13	0.61	0.60	0.58
   query14	2.79	2.74	2.82
   query15	0.89	0.82	0.81
   query16	0.38	0.38	0.38
   query17	1.00	0.98	1.01
   query18	0.20	0.20	0.19
   query19	1.96	1.86	1.99
   query20	0.01	0.00	0.01
   query21	15.35	0.58	0.59
   query22	3.10	2.10	2.09
   query23	17.21	0.88	0.81
   query24	3.18	0.80	0.52
   query25	0.37	0.22	0.09
   query26	0.19	0.14	0.13
   query27	0.05	0.04	0.05
   query28	11.31	1.09	1.07
   query29	12.56	3.24	3.16
   query30	0.25	0.06	0.06
   query31	2.89	0.38	0.38
   query32	3.27	0.47	0.46
   query33	2.99	2.95	3.03
   query34	16.98	4.50	4.49
   query35	4.56	4.53	4.50
   query36	0.65	0.49	0.47
   query37	0.09	0.06	0.06
   query38	0.05	0.03	0.04
   query39	0.03	0.03	0.02
   query40	0.15	0.12	0.12
   query41	0.07	0.02	0.02
   query42	0.03	0.02	0.02
   query43	0.04	0.03	0.02
   Total cold run time: 108.32 s
   Total hot run time: 32.37 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425531080

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41238 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 5938b1bece44661efe28f9c81f77a272f6b9992d, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17599	7491	7332	7332
   q2	2036	275	272	272
   q3	12369	1077	1197	1077
   q4	10559	862	802	802
   q5	7763	3106	3083	3083
   q6	240	160	152	152
   q7	1047	629	603	603
   q8	9360	1970	1970	1970
   q9	6582	6441	6436	6436
   q10	7101	2409	2444	2409
   q11	441	247	248	247
   q12	413	224	220	220
   q13	17784	2974	2998	2974
   q14	246	218	216	216
   q15	561	520	519	519
   q16	631	608	583	583
   q17	975	518	528	518
   q18	7367	6793	6738	6738
   q19	1360	850	903	850
   q20	485	182	185	182
   q21	4048	3245	3053	3053
   q22	1125	1010	1002	1002
   Total cold run time: 110092 ms
   Total hot run time: 41238 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7358	7350	7300	7300
   q2	324	227	233	227
   q3	3062	3012	2940	2940
   q4	2080	1816	1818	1816
   q5	5765	5781	5860	5781
   q6	243	152	149	149
   q7	2320	1892	1796	1796
   q8	3466	3553	3524	3524
   q9	8974	8962	8994	8962
   q10	3603	3587	3575	3575
   q11	590	503	484	484
   q12	884	637	623	623
   q13	9208	3178	3220	3178
   q14	307	274	271	271
   q15	599	532	522	522
   q16	705	660	657	657
   q17	1880	1642	1591	1591
   q18	8295	7773	7500	7500
   q19	1724	1522	1635	1522
   q20	2150	1887	1893	1887
   q21	5607	5363	5484	5363
   q22	1140	1039	1042	1039
   Total cold run time: 70284 ms
   Total hot run time: 60707 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425481772

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425488486

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42147:
URL: https://github.com/apache/doris/pull/42147#issuecomment-2425669361

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](minor) Remove unused Partitioner [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #42147:
URL: https://github.com/apache/doris/pull/42147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org