You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/10 16:35:03 UTC
[GitHub] [helix] alirezazamani opened a new pull request #944: Add
CustomizedView Root Change Listener to Router
alirezazamani opened a new pull request #944: Add CustomizedView Root Change Listener to Router
URL: https://github.com/apache/helix/pull/944
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR title:
Fixes #943
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
In this PR, a new logic is added which targets the scenario where user
disables and enables specific CustomizedView types in the config. In this case, since the CustomizedView path for that type is removed by the controller, the router looses its
listener. In this commit, we added root change lister and re-registers the listeners again.
### Tests
- [x] The following is the result of the "mvn test" command on the appropriate module:
Test Result 1 (Helix-Core): mvn test
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestJobQueueCleanUp.testJobQueueAutoCleanUp ยป ThreadTimeout Method org.testng....
[ERROR] TestWorkflowTermination.testWorkflowRunningTimeout:131->verifyWorkflowCleanup:257 expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 923, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:05 h
[INFO] Finished at: 2020-04-09T18:25:01-07:00
[INFO] ------------------------------------------------------------------------
Test Result 2 (Helix-Core): mvn test -Dtest="TestJobQueueCleanUp,TestWorkflowTermination"
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.725 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.258 s
[INFO] Finished at: 2020-04-10T09:31:45-07:00
[INFO] ------------------------------------------------------------------------
Test Result (Helix-REST):
[INFO] Tests run: 97, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.546 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 97, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32.660 s
[INFO] Finished at: 2020-04-10T09:29:13-07:00
[INFO] ------------------------------------------------------------------------
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on a change in pull request #944:
Add CustomizedView Root Change Listener to the Router
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on a change in pull request #944: Add CustomizedView Root Change Listener to the Router
URL: https://github.com/apache/helix/pull/944#discussion_r406877810
##########
File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -683,6 +694,27 @@ public void onCustomizedViewChange(List<CustomizedView> customizedViewList,
}
}
+ @Override
+ @PreFetch(enabled = false)
+ public void onCustomizedViewRootChange(List<String> customizedViewTypes,
Review comment:
I added prefetch to the code in case we want to enable it in the future. However, we do not use it here. At the end of the day, I think intersection does not matter and here we only need to register what user requested. Please let me know if that answers your question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on issue #944: Add CustomizedView
Root Change Listener to the Router
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on issue #944: Add CustomizedView Root Change Listener to the Router
URL: https://github.com/apache/helix/pull/944#issuecomment-612182093
This PR is ready to be merged, approved by @zhangmeng916
Final commit message:
Add registration logic for CustomizedView listeners
In this commit, a new logic is added which target the scenario where user
disables and enables specific types. In this case, since the CustomizedView
path for that type is removed by the controller, the router looses its
listener. In this commit, we added root change lister and re-registers the
listeners again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #944:
Add CustomizedView Root Change Listener to the Router
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #944: Add CustomizedView Root Change Listener to the Router
URL: https://github.com/apache/helix/pull/944#discussion_r406858418
##########
File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -683,6 +694,27 @@ public void onCustomizedViewChange(List<CustomizedView> customizedViewList,
}
}
+ @Override
+ @PreFetch(enabled = false)
+ public void onCustomizedViewRootChange(List<String> customizedViewTypes,
Review comment:
So the prefetched type is not used anywhere. I think we should add listeners to the intersection of the available types and the user required types, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #944: Add CustomizedView
Root Change Listener to the Router
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #944: Add CustomizedView Root Change Listener to the Router
URL: https://github.com/apache/helix/pull/944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org