You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/23 00:48:25 UTC
[GitHub] [skywalking-rust] jmjoy opened a new pull request, #35: Add serde support for protobuf generated struct.
jmjoy opened a new pull request, #35:
URL: https://github.com/apache/skywalking-rust/pull/35
So protobuf generated struct can be serialized and deserialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter commented on pull request #35: Add serde support for protobuf generated struct.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #35:
URL: https://github.com/apache/skywalking-rust/pull/35#issuecomment-1193025637
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/35?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#35](https://codecov.io/gh/apache/skywalking-rust/pull/35?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f97bfd) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/b5ac538878addf85eb5436d4d25a086bb65b9b9c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5ac538) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 38.88% 38.88%
=======================================
Files 13 13
Lines 306 306
=======================================
Hits 119 119
Misses 187 187
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-rust/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/skywalking\_proto/v3/mod.rs](https://codecov.io/gh/apache/skywalking-rust/pull/35/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3NreXdhbGtpbmdfcHJvdG8vdjMvbW9kLnJz) | `0.00% <ø> (ø)` | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #35: Add serde support for protobuf generated struct.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #35:
URL: https://github.com/apache/skywalking-rust/pull/35#issuecomment-1193039301
I see. So, the serialization would change to use serde automatically after this change, we don't need explicitly calling the method, it is integrated into generated codes. Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #35: Add serde support for protobuf generated struct.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #35:
URL: https://github.com/apache/skywalking-rust/pull/35#issuecomment-1193038807
> Curious question, how we do serialization now?
The protobuf library use it's own trait [prost::Message](https://docs.rs/prost/latest/prost/trait.Message.html), not the most common serialize/deserialize library `serde`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng merged pull request #35: Add serde support for protobuf generated struct.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #35:
URL: https://github.com/apache/skywalking-rust/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on a diff in pull request #35: Add serde support for protobuf generated struct.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on code in PR #35:
URL: https://github.com/apache/skywalking-rust/pull/35#discussion_r928057206
##########
Cargo.toml:
##########
@@ -44,6 +44,7 @@ futures-core = "0.3.21"
futures-util = "0.3.21"
prost = "0.10.4"
prost-derive = "0.10.1"
+serde = { version = "1.0.138", features = ["derive"] }
Review Comment:
There will be a new dependency [serde_derive](https://crates.io/crates/serde_derive), it's under [MIT ](https://choosealicense.com/licenses/mit)OR [Apache-2.0](https://choosealicense.com/licenses/apache-2.0) license, so it's OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #35: Add serde support for protobuf generated struct.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #35:
URL: https://github.com/apache/skywalking-rust/pull/35#issuecomment-1193040535
> I see. So, the serialization would change to use serde automatically after this change, we don't need explicitly calling the method, it is integrated into generated codes. Am I right?
Yes, for the serialization scenes which need `serde`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org