You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2017/03/29 12:46:41 UTC

[jira] [Created] (OAK-6001) FileStore.GarbageCollector#collectBulkReferences performs unnecessary operations

Francesco Mari created OAK-6001:
-----------------------------------

             Summary: FileStore.GarbageCollector#collectBulkReferences performs unnecessary operations
                 Key: OAK-6001
                 URL: https://issues.apache.org/jira/browse/OAK-6001
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: segment-tar
            Reporter: Francesco Mari
            Assignee: Francesco Mari


{{FileStore.GarbageCollector#collectBulkReferences}} looks into the currently active {{TarWriter}} for references. At the time this method is invoked, the currently active {{TarWriter}} is always empty.

Slightly before inspecting the {{TarWriter}}, {{FileStore#newWriter}} is called to flush the content of the current {{TarWriter}} and to create a fresh one. For this reason, inspecting the {{TarWriter}} in {{FileStore.GarbageCollector#collectBulkReferences}} is unnecessary - the graph of the {{TarWriter}} is always empty. Those lines of code can be safely removed.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)