You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "dugenkui03 (GitHub)" <gi...@apache.org> on 2018/10/02 14:07:36 UTC
[GitHub] [incubator-dubbo] dugenkui03 opened pull request #2594: 3.x
dev cache
## What is the purpose of the change
improve the implementation of cache，especially ThreadLocalCache and ExpiringCache, to prevents memory leak.
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2594: 3.x dev
cache
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Hi, @dugenkui03
I will close this pr. Expect you to be able to provide a complete cleanup caching strategy.
:)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] kimmking commented on pull request #2594:
3.x dev cache
Posted by "kimmking (GitHub)" <gi...@apache.org>.
how to use it?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2594: 3.x
dev cache
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2594?src=pr&el=h1) Report
> Merging [#2594](https://codecov.io/gh/apache/incubator-dubbo/pull/2594?src=pr&el=desc) into [3.x-dev](https://codecov.io/gh/apache/incubator-dubbo/commit/2faf5e71f8cdb732e0234359594c668f39d82157?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2594?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.x-dev #2594 +/- ##
=============================================
- Coverage 54.93% 54.87% -0.07%
+ Complexity 5276 5272 -4
=============================================
Files 573 573
Lines 25517 25534 +17
Branches 4531 4531
=============================================
- Hits 14018 14011 -7
- Misses 9395 9416 +21
- Partials 2104 2107 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2594?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlLmphdmE=) | `58.33% <0%> (-41.67%)` | `3 <0> (ø)` | |
| [.../org/apache/dubbo/cache/support/jcache/JCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9qY2FjaGUvSkNhY2hlLmphdmE=) | `74.07% <0%> (-12.89%)` | `4 <0> (ø)` | |
| [...a/org/apache/dubbo/cache/support/lru/LruCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9scnUvTHJ1Q2FjaGUuamF2YQ==) | `63.63% <0%> (-36.37%)` | `3 <0> (ø)` | |
| [...he/dubbo/cache/support/expiring/ExpiringCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9leHBpcmluZy9FeHBpcmluZ0NhY2hlLmphdmE=) | `71.42% <0%> (-28.58%)` | `3 <0> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `42.25% <0%> (-11.27%)` | `15% <0%> (-1%)` | |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `77.77% <0%> (-11.12%)` | `5% <0%> (-2%)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `37.5% <0%> (-4.17%)` | `3% <0%> (ø)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `54.21% <0%> (-3.62%)` | `13% <0%> (-2%)` | |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `55.6% <0%> (-1.73%)` | `35% <0%> (-3%)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `50.71% <0%> (-0.36%)` | `42% <0%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2594/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2594?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2594?src=pr&el=footer). Last update [2faf5e7...40ad5ca](https://codecov.io/gh/apache/incubator-dubbo/pull/2594?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] dugenkui03 commented on pull request
#2594: 3.x dev cache
Posted by "dugenkui03 (GitHub)" <gi...@apache.org>.
when user want to Invalidate cache,espescially in ThreadLocalCache.details about this commit can be found in [#2592](https://github.com/apache/incubator-dubbo/issues/2592)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed pull request #2594: 3.x
dev cache
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ pull request closed by carryxyh ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] dugenkui03 commented on pull request
#2594: 3.x dev cache
Posted by "dugenkui03 (GitHub)" <gi...@apache.org>.
when user want to Invalidate cache,espescially in ThreadLocalCache.details about this commit can be found in [#2592](https://github.com/apache/incubator-dubbo/issues/2592)
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2594: 3.x dev
cache
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Do not agree with this pr. Unless a complete set of expiration policies can be provided.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org