You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zjf2012 (via GitHub)" <gi...@apache.org> on 2023/02/24 08:54:27 UTC

[GitHub] [incubator-uniffle] zjf2012 commented on pull request #637: [#615] improvement: Reduce task binary by removing 'partitionToServers' from RssShuffleHandle

zjf2012 commented on PR #637:
URL: https://github.com/apache/incubator-uniffle/pull/637#issuecomment-1443202413

   > > …m RssShuffleHandle
   > > ### What changes were proposed in this pull request?
   > > move partition -> shuffle servers mapping from direct field of RssShuffleHandle to a broadcast variable to reduce task binary size.
   > > ### Why are the changes needed?
   > > to reduce task delay and task serialize/deserialize time by reduce task binary size
   > > ### Does this PR introduce _any_ user-facing change?
   > > No.
   > > ### How was this patch tested?
   > > 
   > > 1. tested with 10000 partitions shuffle. Task binary size reduced from more than 670KB to less than 6KB.
   > > 2. tested with multiple shuffle stages in same job to verify ShuffleHandleInfo cache logic
   > 
   > Could you modify the title and description? It seems that the title is too long, some words of title were added to description.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org