You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by pd...@apache.org on 2016/02/10 08:56:12 UTC

svn commit: r1729543 - /felix/trunk/dependencymanager/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/FactoryConfigurationAdapterImpl.java

Author: pderop
Date: Wed Feb 10 07:56:12 2016
New Revision: 1729543

URL: http://svn.apache.org/viewvc?rev=1729543&view=rev
Log:
FELIX-5177: refactoring: removed unecessary catch in updateService method.

Modified:
    felix/trunk/dependencymanager/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/FactoryConfigurationAdapterImpl.java

Modified: felix/trunk/dependencymanager/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/FactoryConfigurationAdapterImpl.java
URL: http://svn.apache.org/viewvc/felix/trunk/dependencymanager/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/FactoryConfigurationAdapterImpl.java?rev=1729543&r1=1729542&r2=1729543&view=diff
==============================================================================
--- felix/trunk/dependencymanager/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/FactoryConfigurationAdapterImpl.java (original)
+++ felix/trunk/dependencymanager/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/FactoryConfigurationAdapterImpl.java Wed Feb 10 07:56:12 2016
@@ -163,17 +163,11 @@ public class FactoryConfigurationAdapter
             Component service = (Component) properties[1];
             CallbackTypeDef callbackInfo = createCallbackType(m_logger, service, m_configType, cmSettings);
 
-            try {
-                invokeUpdated(service, callbackInfo);
+            invokeUpdated(service, callbackInfo);
 
-                if (m_serviceInterfaces != null && m_propagate == true) {
-                    Dictionary<String, ?> serviceProperties = getServiceProperties(cmSettings);
-                    service.setServiceProperties(serviceProperties);
-                }
-            }
-            
-            catch (Throwable t) {
-                handleException(t);
+            if (m_serviceInterfaces != null && m_propagate == true) {
+                Dictionary<String, ?> serviceProperties = getServiceProperties(cmSettings);
+                service.setServiceProperties(serviceProperties);
             }
         }