[GitHub] [incubator-superset] oskarhinc commented on a change in pull request #8296: #8294: Set moment library language during app setup

[GitBox <gi...@apache.org>]

oskarhinc commented on a change in pull request #8296: #8294: Set moment library language during app setup
URL: https://github.com/apache/incubator-superset/pull/8296#discussion_r328481685
 
 

 ##########
 File path: superset/assets/src/setup/setupApp.js
 ##########
 @@ -20,6 +20,16 @@
 import $ from 'jquery';
 import { SupersetClient } from '@superset-ui/connection';
 import getClientErrorObject from '../utils/getClientErrorObject';
+import moment from 'moment';
+import localStorage from 'local-storage';
 
 Review comment:
   You're right, it's not needed in this case - I'm just used to using it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org