You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2012/06/27 21:09:42 UTC
[jira] [Created] (HBASE-6282) The introspection, etc. of objects in
the RPC has to be handled for PB objects
Devaraj Das created HBASE-6282:
----------------------------------
Summary: The introspection, etc. of objects in the RPC has to be handled for PB objects
Key: HBASE-6282
URL: https://issues.apache.org/jira/browse/HBASE-6282
Project: HBase
Issue Type: Bug
Components: ipc
Reporter: Devaraj Das
Fix For: 0.96.0
The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6282) The introspection, etc. of objects in
the RPC has to be handled for PB objects
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6282:
-------------------------
Attachment: 6282addendum.txt
6282addendum.txt
Addendum committed to trunk that adds printing of the response we send back (Original patch just does the request)
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282addendum.txt, 6282addendum.txt, 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497668#comment-13497668 ]
stack commented on HBASE-6282:
------------------------------
If I enable IPC trace, its not bad as is:
{code}
...e.hadoop.ipc.HBaseServer.trace: Call #18; Served: ClientProtocol#multi queueTime=1 processingTime=0 contents=1 MultiRequest
{code}
I can call toString on the pb param. This is totally obnoxious but would be a nice option to have debugging. Let me post a patch.
Regards the logResponse, that needs fixup in general. I had it recently and found the message reported close to useless. Lets file a new issue to fix that distinct from pb'ing.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497684#comment-13497684 ]
Devaraj Das commented on HBASE-6282:
------------------------------------
Yeah [~stack], seems reasonable to me. +1
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497670#comment-13497670 ]
stack commented on HBASE-6282:
------------------------------
Any chance of review on this?
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432055#comment-13432055 ]
Devaraj Das commented on HBASE-6282:
------------------------------------
BTW the patch in HBASE-6414 addresses the QosFunction part.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497949#comment-13497949 ]
Hudson commented on HBASE-6282:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #262 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/262/])
HBASE-6282 The introspection, etc. of objects in the RPC has to be handled for PB objects (Revision 1409648)
HBASE-6282 The introspection, etc. of objects in the RPC has to be handled for PB objects (Revision 1409643)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Objects.java
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282addendum.txt, 6282addendum.txt, 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474381#comment-13474381 ]
Devaraj Das commented on HBASE-6282:
------------------------------------
bq. We don't need to do '...and the private WritableRpcEngine.Server.logResponse method also needs updating' because WritableRpcEngine has been removed?
Sorry, missed this question.. Actually I had moved logResponse to ProtobufRpcEngine as part of some jira.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497765#comment-13497765 ]
Hudson commented on HBASE-6282:
-------------------------------
Integrated in HBase-TRUNK #3544 (See [https://builds.apache.org/job/HBase-TRUNK/3544/])
HBASE-6282 The introspection, etc. of objects in the RPC has to be handled for PB objects (Revision 1409643)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Objects.java
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473902#comment-13473902 ]
stack commented on HBASE-6282:
------------------------------
What do I need to do here [~devaraj]? Enable trace on RPC and I'll see all the problems above (the pb objects will come out all binary?)
We don't need to do '...and the private WritableRpcEngine.Server.logResponse method also needs updating' because WritableRpcEngine has been removed?
How do I see output from 'MonitoredRPCHandlerImpl.toMap()'?
Thanks DD.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497815#comment-13497815 ]
Hudson commented on HBASE-6282:
-------------------------------
Integrated in HBase-TRUNK #3545 (See [https://builds.apache.org/job/HBase-TRUNK/3545/])
HBASE-6282 The introspection, etc. of objects in the RPC has to be handled for PB objects (Revision 1409648)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282addendum.txt, 6282addendum.txt, 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497775#comment-13497775 ]
stack commented on HBASE-6282:
------------------------------
Committed the addendum.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282addendum.txt, 6282addendum.txt, 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410705#comment-13410705 ]
Devaraj Das commented on HBASE-6282:
------------------------------------
To add to the list, QosFunction in the HRegionServer class needs to be updated (the method arguments, etc. are going to be PB types when the PB objects are used).
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Devaraj Das
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6282) The introspection, etc. of objects in
the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6282:
-------------------------------
Priority: Blocker (was: Major)
Upgrading the Priority so that it gets due attention (maybe after a couple of more PB jira fixes).
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6282) The introspection, etc. of objects in
the RPC has to be handled for PB objects
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6282:
-------------------------
Attachment: 6282.txt
Lets apply this and close this issue. W/ this applied, if you enable TRACE, you see this kinda of stuff:
{code}
2012-11-14 16:57:48,441 DEBUG org.apache.hadoop.ipc.HBaseServer.trace: Call #101; Served: RegionServerStatusProtocol#regionServerReport queueTime=1 processingTime=0 contents=server {
hostName: "android_352668048612046"
port: 59354
startCode: 1352940891735
}
load {
numberOfRequests: 0
totalNumberOfRequests: 44
usedHeapMB: 31
maxHeapMB: 987
regionLoads {
regionSpecifier {
type: REGION_NAME
value: ".META.,,1"
}
stores: 1
storefiles: 0
storeUncompressedSizeMB: 0
storefileSizeMB: 0
memstoreSizeMB: 0
storefileIndexSizeMB: 0
readRequestsCount: 4
writeRequestsCount: 0
totalCompactingKVs: 0
currentCompactedKVs: 0
rootIndexSizeKB: 0
totalStaticIndexSizeKB: 0
totalStaticBloomSizeKB: 0
completeSequenceId: 18446744073709551615
}
regionLoads {
regionSpecifier {
type: REGION_NAME
value: "-ROOT-,,0"
}
stores: 1
storefiles: 1
storeUncompressedSizeMB: 0
storefileSizeMB: 0
memstoreSizeMB: 0
storefileIndexSizeMB: 0
readRequestsCount: 26
writeRequestsCount: 1
totalCompactingKVs: 0
currentCompactedKVs: 0
rootIndexSizeKB: 0
totalStaticIndexSizeKB: 0
totalStaticBloomSizeKB: 0
completeSequenceId: 18446744073709551615
}
reportStartTime: 1352941065437
reportEndTime: 1352941068438
infoServerPort: 60030
}
{code}
It is ridiculous detail but could be life saver debugging.
Could later work on pb toStringing so it doesn't dump it all... just start of String and a length instead but this should be good for now.
Remove Objects class since no longer used.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422564#comment-13422564 ]
Devaraj Das commented on HBASE-6282:
------------------------------------
MonitoredRPCHandlerImpl.toMap() also needs to be updated.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Devaraj Das
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-6282.
--------------------------
Resolution: Fixed
Assignee: stack
Release Note: Enable IPC trace and see all of the calls coming into the server toString'd. Its a load of data but could be useful debugging.
Hadoop Flags: Reviewed
Thanks for review Devaraj. Committed to trunk.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 6282.txt
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6282) The introspection, etc. of objects
in the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474356#comment-13474356 ]
Devaraj Das commented on HBASE-6282:
------------------------------------
bq. What do I need to do here Devaraj Das? Enable trace on RPC and I'll see all the problems above (the pb objects will come out all binary?)
[~stack] Thanks for taking a look at this. Yes, I guess that's what you'd see..
I think most of the changes would be similar to the changes that I did to the QosFunction as part of HBASE-6414.
bq. How do I see output from 'MonitoredRPCHandlerImpl.toMap()'?
I guess this is used in the UI side. I see toJSON (that internally invokes toMap) being called from within TaskMonitorTmpl.jamon.
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6282) The introspection, etc. of objects in
the RPC has to be handled for PB objects
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6282:
-------------------------------
Issue Type: Sub-task (was: Bug)
Parent: HBASE-5305
> The introspection, etc. of objects in the RPC has to be handled for PB objects
> ------------------------------------------------------------------------------
>
> Key: HBASE-6282
> URL: https://issues.apache.org/jira/browse/HBASE-6282
> Project: HBase
> Issue Type: Sub-task
> Components: ipc
> Reporter: Devaraj Das
> Priority: Blocker
> Fix For: 0.96.0
>
>
> The places where the type of objects are inspected need to be updated to take into consideration PB types. I have noticed Objects.describeQuantity being used, and the private WritableRpcEngine.Server.logResponse method also needs updating (in the PB world, all information about operations/tablenames is contained in one PB argument).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira