You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ywgrit (via GitHub)" <gi...@apache.org> on 2024/02/20 11:38:25 UTC
[I] A little question about the sort implementation [arrow]
ywgrit opened a new issue, #40152:
URL: https://github.com/apache/arrow/issues/40152
### Describe the enhancement requested
Hi all.
I was reading the implementation of the sort operator and found that TableSorter::SortInternal calls BatchesFromTable to get Record batches:
`ARROW_ASSIGN_OR_RAISE(RecordBatchVector batches. BatchesFromTable(table_));`
, but TableSorter already builds batches_ in the constructor, so why not just use it?
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] A little question about the sort implementation [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #40152:
URL: https://github.com/apache/arrow/issues/40152#issuecomment-1954160257
cc @benibus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] A little question about the sort implementation [arrow]
Posted by "ywgrit (via GitHub)" <gi...@apache.org>.
ywgrit commented on issue #40152:
URL: https://github.com/apache/arrow/issues/40152#issuecomment-1955719944
> Good question, do you want to try submitting a PR?
Sure, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] A little question about the sort implementation [arrow]
Posted by "ywgrit (via GitHub)" <gi...@apache.org>.
ywgrit commented on issue #40152:
URL: https://github.com/apache/arrow/issues/40152#issuecomment-1955737954
> > Good question, do you want to try submitting a PR?
> > Sure, thanks
Take, in [#40173](https://github.com/apache/arrow/pull/40173)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] A little question about the sort implementation [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #40152: [C++] A little question about the sort implementation
URL: https://github.com/apache/arrow/issues/40152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] A little question about the sort implementation [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #40152:
URL: https://github.com/apache/arrow/issues/40152#issuecomment-1971081568
Issue resolved by pull request 40173
https://github.com/apache/arrow/pull/40173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] A little question about the sort implementation [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #40152:
URL: https://github.com/apache/arrow/issues/40152#issuecomment-1954553129
Good question, do you want to try submitting a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org