You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2018/06/15 00:15:00 UTC
[jira] [Commented] (SOLR-12008) Settle a location for the "correct"
log4j2.xml file.
[ https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513164#comment-16513164 ]
Erick Erickson commented on SOLR-12008:
---------------------------------------
OK, I'm going to nuke as many of these as possible, at minimum 2 of these 3
./example/resources/log4j2.xml
./server/resources/log4j2.xml
./server/scripts/cloud-scripts/log4j2.xml
I propose that we keep ./server/resources/log4j2.xml.
As for the various test ones, I'll look briefly at what they do and whether they seem necessary.
Speak up now about whether these have any known uses so I can be sure and test those usages as I may not discover them on my own.
> Settle a location for the "correct" log4j2.xml file.
> ----------------------------------------------------
>
> Key: SOLR-12008
> URL: https://issues.apache.org/jira/browse/SOLR-12008
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: logging
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> As part of SOLR-11934 I started looking at log4j.properties files. Waaay back in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to use %c, but the file in "solr/example/resources/log4j.properties" was not changed. That got me to looking around and there are a bunch of log4j.properties files:
> ./solr/core/src/test-files/log4j.properties
> ./solr/example/resources/log4j.properties
> ./solr/solrj/src/test-files/log4j.properties
> ./solr/server/resources/log4j.properties
> ./solr/server/scripts/cloud-scripts/log4j.properties
> ./solr/contrib/dataimporthandler/src/test-files/log4j.properties
> ./solr/contrib/clustering/src/test-files/log4j.properties
> ./solr/contrib/ltr/src/test-files/log4j.properties
> ./solr/test-framework/src/test-files/log4j.properties
> Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I propose the logging configuration files get consolidated. The question is "how far"?
> I at least want to get rid of the one in solr/example, users should use the one in server/resources. Having to maintain these two separately is asking for trouble.
> [~markrmiller@gmail.com] Do you have any wisdom on the properties file in server/scripts/cloud-scripts?
> Anyone else who has a clue about why the other properties files were created, especially the ones in contrib?
> And what about all the ones in various test-files directories? People didn't create them for no reason, and I don't want to rediscover that it's a real pain to try to re-use the one in server/resources for instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org