[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #832: Add go test to x.py and improve error in gocase

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #832:
URL: https://github.com/apache/incubator-kvrocks/pull/832#discussion_r964392498


##########
x.py:
##########
@@ -306,6 +320,15 @@ def test_tcl(dir: str, rest: List[str]) -> None:
     parser_test_tcl.add_argument('rest', nargs=REMAINDER, help="the rest of arguments to forward to TCL scripts")
     parser_test_tcl.set_defaults(func=test_tcl)
 
+    parser_test_go = parser_test_subparsers.add_parser(
+        'go',
+        description="Test kvrocks via go test cases",
+        help="Test kvrocks via go test cases",
+    )
+    parser_test_go.add_argument('dir', metavar='BUILD_DIR', nargs='?', default='build', help="directory including kvrocks build files")

Review Comment:
   We treat `build` as a default directory for building and testing, e.g.
   ```
   ./x.py build [build]
   ./x.py test tcl [build]
   ./x.py test go [build]
   ```
   `[build]` can be omitted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org