You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/19 06:26:55 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
AngersZhuuuu opened a new pull request #34327:
URL: https://github.com/apache/spark/pull/34327
### What changes were proposed in this pull request?
Remove unused code in HistoryServer and MetricsSystem 's unit test
### Why are the changes needed?
Fix ut code
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existed UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #34327:
URL: https://github.com/apache/spark/pull/34327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949334122
**[Test build #144532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144532/testReport)** for PR 34327 at commit [`d7898fc`](https://github.com/apache/spark/commit/d7898fc8e0b79a782a22fe8b5bff2136d1451010).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949417334
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949417334
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946410494
**[Test build #144399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144399/testReport)** for PR 34327 at commit [`662cd67`](https://github.com/apache/spark/commit/662cd67182ed4b65ffe889bd20bdf2fa5a3add56).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34327:
URL: https://github.com/apache/spark/pull/34327#discussion_r731975008
##########
File path: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
##########
@@ -91,7 +91,6 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers
val securityManager = HistoryServer.createSecurityManager(conf)
server = new HistoryServer(conf, provider, securityManager, 18080)
- server.initialize()
Review comment:
> Why are we sure this isn't needed?
It has been called when construct HistoryServer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949464538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144532/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946536232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949412379
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946825743
> @AngersZhuuuu What is the worth of just removing `server.initialize()` from the UTs in a single PR? If we will have less benefit, is it better not to bother to remove them now ? When we modify those files, we can remove them together. If you will add new tests to `HistoryServerSuite` in #34326, why don't you remove them in that PR?
Hmm since not related to the target of #34326, so split it to a new pr, remove this in that pr is ok for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946506093
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48872/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949334122
**[Test build #144532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144532/testReport)** for PR 34327 at commit [`d7898fc`](https://github.com/apache/spark/commit/d7898fc8e0b79a782a22fe8b5bff2136d1451010).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949464538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144532/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949370665
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946719580
@AngersZhuuuu What is the worth of just removing `server.initialize()` from the UTs?
If we will have less benefit, is it better not to bother to remove them now ?
When we modify those files, we can remove them together.
If you will add new tests to `HistoryServerSuite` in #34326, why don't you remove them in that PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946456982
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48872/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946532347
**[Test build #144399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144399/testReport)** for PR 34327 at commit [`662cd67`](https://github.com/apache/spark/commit/662cd67182ed4b65ffe889bd20bdf2fa5a3add56).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946536232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-950165289
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946404911
ping @dongjoon-hyun @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946410494
**[Test build #144399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144399/testReport)** for PR 34327 at commit [`662cd67`](https://github.com/apache/spark/commit/662cd67182ed4b65ffe889bd20bdf2fa5a3add56).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34327:
URL: https://github.com/apache/spark/pull/34327#discussion_r733835205
##########
File path: core/src/test/scala/org/apache/spark/metrics/MetricsSystemSuite.scala
##########
@@ -22,7 +22,7 @@ import scala.collection.mutable.ArrayBuffer
import com.codahale.metrics.MetricRegistry
import org.scalatest.{BeforeAndAfter, PrivateMethodTester}
-import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
Review comment:
You cannot remove this after https://github.com/apache/spark/commit/427816d165c5754e0e017bec3fdc7ae34a6786c1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34327:
URL: https://github.com/apache/spark/pull/34327#discussion_r734267519
##########
File path: core/src/test/scala/org/apache/spark/metrics/MetricsSystemSuite.scala
##########
@@ -22,7 +22,7 @@ import scala.collection.mutable.ArrayBuffer
import com.codahale.metrics.MetricRegistry
import org.scalatest.{BeforeAndAfter, PrivateMethodTester}
-import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
Review comment:
> You cannot remove this after [427816d](https://github.com/apache/spark/commit/427816d165c5754e0e017bec3fdc7ae34a6786c1)
Reverted this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-949448594
**[Test build #144532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144532/testReport)** for PR 34327 at commit [`d7898fc`](https://github.com/apache/spark/commit/d7898fc8e0b79a782a22fe8b5bff2136d1451010).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #34327:
URL: https://github.com/apache/spark/pull/34327#issuecomment-946719580
@AngersZhuuuu What is the worth of just removing `server.initialize()` from the UTs in a single PR?
If we will have less benefit, is it better not to bother to remove them now ?
When we modify those files, we can remove them together.
If you will add new tests to `HistoryServerSuite` in #34326, why don't you remove them in that PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34327: [SPARK-37056][CORE] Remove unused code in HistoryServer and MetricsSystem 's unit test
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34327:
URL: https://github.com/apache/spark/pull/34327#discussion_r731816732
##########
File path: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
##########
@@ -91,7 +91,6 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers
val securityManager = HistoryServer.createSecurityManager(conf)
server = new HistoryServer(conf, provider, securityManager, 18080)
- server.initialize()
Review comment:
Why are we sure this isn't needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org