[jira] [Commented] (FLINK-27029) DeploymentValidator should take default flink config into account during validation

["Nicholas Jiang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517576#comment-17517576 ] 

Nicholas Jiang commented on FLINK-27029:
----------------------------------------

[~gyfora], do you mean that in DefaultValidator#validateFlinkConfig, we should validate the default Flink config?

> DeploymentValidator should take default flink config into account during validation
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-27029
>                 URL: https://issues.apache.org/jira/browse/FLINK-27029
>             Project: Flink
>          Issue Type: Bug
>          Components: Kubernetes Operator
>            Reporter: Gyula Fora
>            Priority: Major
>             Fix For: kubernetes-operator-1.0.0
>
>
> Currently the DefaultDeploymentValidator only takes the FlinkDeployment object into account.
> However in places where we validate the presence of config keys we should also consider the default flink config which might already provide default values for the required configs even if the deployment itself doesnt.
> We should make sure this works correctly both in the operator and the webhook



--
This message was sent by Atlassian Jira
(v8.20.1#820001)