You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Rakesh Midha (JIRA)" <ji...@apache.org> on 2006/11/27 07:12:24 UTC
[jira] Created: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Deployment doesn't ensure queries defined for ejbSelect methods
---------------------------------------------------------------
Key: OPENEJB-384
URL: http://issues.apache.org/jira/browse/OPENEJB-384
Project: OpenEJB
Issue Type: Bug
Environment: Windows XP
Reporter: Rakesh Midha
Opening Geronimo JIRA in openEJB https://issues.apache.org/jira/browse/GERONIMO-1082
I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
Rakesh Midha updated OPENEJB-384:
---------------------------------
Attachment: querymissing.patch
Added a code to check the methods in home and bean which starts with "find" or "ejbSelect" but has no configuration.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Environment: Windows XP
> Reporter: Rakesh Midha
> Attachments: querymissing.patch
>
>
> Opening Geronimo JIRA in openEJB https://issues.apache.org/jira/browse/GERONIMO-1082
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
Jacek Laskowski updated OPENEJB-384:
------------------------------------
Component/s: deployment
Description: I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.) (was: Opening Geronimo JIRA in openEJB https://issues.apache.org/jira/browse/GERONIMO-1082
I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.))
Affects Version/s: 2.2
Environment: (was: Windows XP)
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2
> Reporter: Rakesh Midha
> Attachments: querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
David Jencks updated OPENEJB-384:
---------------------------------
Attachment: OPENEJB-384-problem.patch
Patch that lets tests pass for me
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Fix For: 2.2, 2.3
>
> Attachments: OPENEJB-384-problem.patch, querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=comments#action_12453504 ]
Rakesh Midha commented on OPENEJB-384:
--------------------------------------
Sorry, cannot edit this jira as I dont have contributor access. So positing this information as comment.
Component : Deployment
Affect Version : 1.2
Fix Version : 1.2
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Environment: Windows XP
> Reporter: Rakesh Midha
>
> Opening Geronimo JIRA in openEJB https://issues.apache.org/jira/browse/GERONIMO-1082
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
David Jencks reopened OPENEJB-384:
----------------------------------
I think this broke the build for me with failing tests. I'll attach a patch that lets the tests pass but I wonder if there is a better solution than commenting out the ejbSelect methods.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Fix For: 2.2, 2.3
>
> Attachments: OPENEJB-384-problem.patch, querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=comments#action_12454287 ]
Jacek Laskowski commented on OPENEJB-384:
-----------------------------------------
I meant to have fixed it with a cleverer way than disabling the tests, but it seems that the part responsible for providing ejbSelects configuration is in TranQL and there's no way to build the map (that's how ejbSelects are passed along) of ejbSelects in the tests.
Thanks Dave for the patch! It's committed in the 2.2 branch and the trunk. I'll leave the issue open as that's not the final solution yet.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Fix For: 2.2, 2.3
>
> Attachments: OPENEJB-384-problem.patch, querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
Jacek Laskowski resolved OPENEJB-384.
-------------------------------------
Fix Version/s: 2.2
Resolution: Fixed
Committed to the 2.2 branch and the trunk. Please verify.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2
> Reporter: Rakesh Midha
> Fix For: 2.2
>
> Attachments: querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Dain Sundstrom (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
Dain Sundstrom updated OPENEJB-384:
-----------------------------------
Fix Version/s: (was: 2.2)
Assignee: Jacek Laskowski
Jacek please apply the last patch in 2.3 and update the status of this issue.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Assigned To: Jacek Laskowski
> Fix For: 2.3
>
> Attachments: OPENEJB-384-problem.patch, querymissing.patch, testcase.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=comments#action_12453821 ]
Jacek Laskowski commented on OPENEJB-384:
-----------------------------------------
Committed to the trunk.
Sending modules/openejb-core/src/main/java/org/apache/openejb/entity/cmp/TranqlEjbCmpEngine.java
Transmitting file data .
Committed revision 479943.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2
> Reporter: Rakesh Midha
> Attachments: querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
Jacek Laskowski closed OPENEJB-384.
-----------------------------------
Open it when unsatisfied.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Fix For: 2.2, 2.3
>
> Attachments: querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
Rakesh Midha updated OPENEJB-384:
---------------------------------
Attachment: testcase.patch
Patch to add required ejbSelect's
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Fix For: 2.2, 2.3
>
> Attachments: OPENEJB-384-problem.patch, querymissing.patch, testcase.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=comments#action_12453817 ]
Jacek Laskowski commented on OPENEJB-384:
-----------------------------------------
Committed to v2.2 branch.
Sending modules/openejb-core/src/main/java/org/apache/openejb/entity/cmp/TranqlEjbCmpEngine.java
Transmitting file data .
Committed revision 479936.
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2
> Reporter: Rakesh Midha
> Attachments: querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=comments#action_12453506 ]
Rakesh Midha commented on OPENEJB-384:
--------------------------------------
Attached patch, please review and commit
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Environment: Windows XP
> Reporter: Rakesh Midha
> Attachments: querymissing.patch
>
>
> Opening Geronimo JIRA in openEJB https://issues.apache.org/jira/browse/GERONIMO-1082
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=comments#action_12454325 ]
Rakesh Midha commented on OPENEJB-384:
--------------------------------------
My mistake, I should have given you updated testcases to accomodate additional check we added.
Here is the patch for adding required ejbSelects in entityconfiguration.
Please note we don't need OPENEJB-384-problem.patch if we use testcase.patch
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Fix For: 2.2, 2.3
>
> Attachments: OPENEJB-384-problem.patch, querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-384) Deployment doesn't ensure queries
defined for ejbSelect methods
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-384?page=all ]
Jacek Laskowski updated OPENEJB-384:
------------------------------------
Fix Version/s: 2.3
Affects Version/s: 2.3
Add a reference to a just -established 2.3 version
> Deployment doesn't ensure queries defined for ejbSelect methods
> ---------------------------------------------------------------
>
> Key: OPENEJB-384
> URL: http://issues.apache.org/jira/browse/OPENEJB-384
> Project: OpenEJB
> Issue Type: Bug
> Components: deployment
> Affects Versions: 2.2, 2.3
> Reporter: Rakesh Midha
> Fix For: 2.2, 2.3
>
> Attachments: querymissing.patch
>
>
> I deployed a CMP entity bean with an ejbSelect method, but I forgot to actually define a query for it in my ejb-jar.xml. This caused a very bizarre NullPointerException at runtime. Instead, the deployment should check that all ejbSelect methods have queries defined. (And the same for finders, if it doesn't already.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira