You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Lukasz Lenart (JIRA)" <ji...@apache.org> on 2018/12/29 16:23:00 UTC

[jira] [Resolved] (WW-4995) Enhancement for s:set tag to improve tag body whitespace control.

     [ https://issues.apache.org/jira/browse/WW-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart resolved WW-4995.
-------------------------------
    Resolution: Fixed

> Enhancement for s:set tag to improve tag body whitespace control.
> -----------------------------------------------------------------
>
>                 Key: WW-4995
>                 URL: https://issues.apache.org/jira/browse/WW-4995
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Tags
>    Affects Versions: 2.5.18
>         Environment: All environments.
>            Reporter: James Chaplin
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.6, 2.5.19
>
>
> Hello Apache Struts Team.
> The current s:set tag performs an automatic _trim()_ on any body content used (when using the <s:set>something</s:set> style with a body).
> The current behaviour limits white-space control for the text body passed to the s:set tag (and makes assigning a single-or-muliple-character whitespace set - e.g. "  " impossible via the tag body)..
> A proposed improvement is to introduce two optional attributes to the s:set tag which will permit the following:
>  * Allow an override to prevent the trim() from happening (helps to preserve existing whitespace)..
>  * Allow the optional removal of all line-breaks from the tag body content (to allow vertical collapsing of tag body content without impacting anything else).
> There is a PR available with a proposed implementation for the enhancement.  I believe having this additional flexibility will be beneficial for some JSP content generation scenarios.
> Please review and advise if this minor enhancement can be considered for inclusion in 2.5.19 (and then ported forward for 2.6).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)