[GitHub] [ozone] sumitagrawl commented on pull request #3751: HDDS-6492. Add metric for failed container moves

[GitBox <gi...@apache.org>]

sumitagrawl commented on PR #3751:
URL: https://github.com/apache/ozone/pull/3751#issuecomment-1248137129

   > Overall, I think it's better to count failed moves in the `whenComplete((result, ex)` stage of completable future in the `moveContainer` method. That way, we can count all the failures at one place. `checkIterationMoveResults` can be used for updating aggregate metrics (across all iterations). @sumitagrawl What do you think?
   
   I checked internet, replication.move() should return completable failure, and must not throw exception to get in whenComplete() handling, currently replication code is not written in this manner, so exception will never come.
   eg:
   CompletableFuture<String> cf0 =
       CompletableFuture.failedFuture(new RuntimeException("Oops"));


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org