You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by cm...@apache.org on 2010/06/24 21:21:58 UTC
svn commit: r957690 - /subversion/trunk/subversion/svnserve/serve.c
Author: cmpilato
Date: Thu Jun 24 19:21:57 2010
New Revision: 957690
URL: http://svn.apache.org/viewvc?rev=957690&view=rev
Log:
* subversion/svnserve/serve.c
(get_location_segments): Use log_fail_and_flush() to properly handle
incorrect parameters.
Modified:
subversion/trunk/subversion/svnserve/serve.c
Modified: subversion/trunk/subversion/svnserve/serve.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnserve/serve.c?rev=957690&r1=957689&r2=957690&view=diff
==============================================================================
--- subversion/trunk/subversion/svnserve/serve.c (original)
+++ subversion/trunk/subversion/svnserve/serve.c Thu Jun 24 19:21:57 2010
@@ -2154,16 +2154,22 @@ static svn_error_t *get_location_segment
if (SVN_IS_VALID_REVNUM(start_rev)
&& SVN_IS_VALID_REVNUM(end_rev)
&& (end_rev > start_rev))
- return svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL,
- "Get-location-segments end revision must not be "
- "younger than start revision");
+ {
+ err = svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL,
+ "Get-location-segments end revision must not be "
+ "younger than start revision");
+ return log_fail_and_flush(err, b, conn, pool);
+ }
if (SVN_IS_VALID_REVNUM(peg_revision)
&& SVN_IS_VALID_REVNUM(start_rev)
&& (start_rev > peg_revision))
- return svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL,
- "Get-location-segments start revision must not "
- "be younger than peg revision");
+ {
+ err = svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL,
+ "Get-location-segments start revision must not "
+ "be younger than peg revision");
+ return log_fail_and_flush(err, b, conn, pool);
+ }
SVN_ERR(trivial_auth_request(conn, pool, b));
SVN_ERR(log_command(baton, conn, pool, "%s",