You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/04 17:40:07 UTC

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #2128: [doc][connector-v2] pulsar source options doc

ashulin opened a new pull request, #2128:
URL: https://github.com/apache/incubator-seatunnel/pull/2128

<!--

Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

## Contribution Checklist

- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).

- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.

- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.

-->

## Purpose of this pull request
Simplify option's name and add detailed documentation

## Check list

* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2128: [doc][connector-v2] pulsar source options doc

Posted by GitBox <gi...@apache.org>.

Hisoka-X commented on code in PR #2128:
URL: https://github.com/apache/incubator-seatunnel/pull/2128#discussion_r913336713


##########
docs/en/connector-v2/source/pulsar.md:
##########
@@ -0,0 +1,42 @@
+# Apache Pulsar
+
+## Description
+
+Source connector for Apache Pulsar. It can support both off-line and real-time jobs.
+
+##  Options

Review Comment:
   Hi, the option format please check other doc, we should display every option in single sub module. After this every connector's doc format will be same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2128: [doc][connector-v2] pulsar source options doc

Posted by GitBox <gi...@apache.org>.

Hisoka-X merged PR #2128:
URL: https://github.com/apache/incubator-seatunnel/pull/2128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2128: [doc][connector-v2] pulsar source options doc

Posted by GitBox <gi...@apache.org>.

ashulin commented on code in PR #2128:
URL: https://github.com/apache/incubator-seatunnel/pull/2128#discussion_r914708432


##########
docs/en/connector-v2/source/pulsar.md:
##########
@@ -0,0 +1,42 @@
+# Apache Pulsar
+
+## Description
+
+Source connector for Apache Pulsar. It can support both off-line and real-time jobs.
+
+##  Options

Review Comment:
   I changed the doc style to keep it consistent with the other connectors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org