[GitHub] [flink] zhijiangW opened a new pull request #10617: [FLINK-15021][network] Remove setting of netty channel watermark and logic of writability changed

[GitBox <gi...@apache.org>]

zhijiangW opened a new pull request #10617: [FLINK-15021][network] Remove setting of netty channel watermark and logic of writability changed
URL: https://github.com/apache/flink/pull/10617
 
 
   ## What is the purpose of the change
   
   *After removing the non credit-based flow control codes, the channel writability changed logic in `PartitionRequestQueue` along with the setting of channel watermark are both invalid. Therefore we can remove them completely to simplify the codes.*
   
   ## Brief change log
   
     - *Remove the watermark setting in `NettyServer`*
     - *Remove the logic of  *channelWritabilityChanged` in `PartitionRequestQueue`
     - *Refactor some relevant unit tests*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *PartitionRequestQueueTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services