[jira] [Created] (MESOS-9353) Get libprocess to build against openssl 1.1 without deprecation warnings.

["Till Toenshoff (JIRA)" <ji...@apache.org>]

Till Toenshoff created MESOS-9353:
-------------------------------------

             Summary: Get libprocess to build against openssl 1.1 without deprecation warnings. 
                 Key: MESOS-9353
                 URL: https://issues.apache.org/jira/browse/MESOS-9353
             Project: Mesos
          Issue Type: Bug
          Components: build, libprocess
    Affects Versions: 1.8.0
            Reporter: Till Toenshoff


When building libprocess against libevent and openssl 1.1, the results are deprecation warnings;

{noformat}
../3rdparty/libprocess/src/openssl.cpp:764:39: warning: 'ASN1_STRING_data' is deprecated [-Wdeprecated-declarations]
              reinterpret_cast<char*>(ASN1_STRING_data(
                                      ^
/usr/include/openssl/asn1.h:553:1: note: 'ASN1_STRING_data' has been explicitly marked deprecated here
DEPRECATEDIN_1_1_0(unsigned char *ASN1_STRING_data(ASN1_STRING *x))
^
/usr/include/openssl/opensslconf-x86_64.h:122:34: note: expanded from macro 'DEPRECATEDIN_1_1_0'
# define DEPRECATEDIN_1_1_0(f)   DECLARE_DEPRECATED(f)
                                 ^
/usr/include/openssl/opensslconf-x86_64.h:96:56: note: expanded from macro 'DECLARE_DEPRECATED'
#    define DECLARE_DEPRECATED(f)    f __attribute__ ((deprecated));
                                                       ^
{noformat}

These warnings are benign and can get ignored for now, as long as no warning to error escalation is active. For successful builds we need to activate {{disable-werror}} for autotools - cmake builds do not escalate warnings to errors by default.

We should still fix those warnings, likely by adapting towards openssl1.1 via preprocessor/define  gates like;

{noformat}
#if OPENSSL_VERSION_NUMBER < 0x10100000L
  [leave code as is]
#else
  [add variant that does not rely on deprecated the ASN1_STRING_data]
#endif
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)