Re: svn diff auth bug

["Andreas J. Koenig" <an...@anima.de>]

It's nearly two months since...

>>>>> On 18 Oct 2002 08:49:55 -0500, Ben Collins-Sussman <su...@collab.net> said:

  > Rafael Garcia-Suarez <ra...@hexaflux.com> writes:
 >> I've an http svn server that requires a valid user for all http methods,
 >> and a working copy with cached auth tokens. But the command
 >> "svn diff -r <rev#> targets" still asks me for a password. This behavior
 >> disappears if I make the http server accessible for anyone for the GET,
 >> PROPFIND, OPTIONS and REPORT methods. (Apparently there is no issue
 >> filled for this bug yet.)
 >> 
 >> I could try to fix this by myself if I find some time -- has someone
 >> any tuits on where to look ?

  > We have three different code paths for 'svn diff':

  >    * working compared to text-base  (no network)

  >    * working compared to URL

  >    * URL compared to URL


  > The latter two cases are fancy diff editors -- one lives in libsvn_wc,
  > the other in libsvn_client, I believe.  They both involve calling
 RA-> get_file() into a temporary file, which is then diffed against
  > either your working file, or another temp file.

  > So the issue here, I'm guessing, is that for the 2nd case (which
  > you're using) RA->get_file() isn't using any auth in the working copy.
  > For our 3rd codepath, this is expected behavior -- it assumes that no
  > working copy exists.  But for the 2nd codepath, we should probably be
  > opening the RA session differently, i.e. with access to a working copy
  > (and thus its cache.)


I just discovered that this issue still exists but is not filed as an
issue. Shouldn't it either be fixed or filed?


-- 
andreas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn diff auth bug

[Karl Fogel <kf...@newton.ch.collab.net>]

andreas.koenig@anima.de (Andreas J. Koenig) writes:
>   > I think so.  Could you file it?
> 
> Filed as issue #1038.

Thank you, sir.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn diff auth bug

["Andreas J. Koenig" <an...@anima.de>]

>>>>> On 10 Dec 2002 10:06:13 -0600, Karl Fogel <kf...@newton.ch.collab.net> said:

  > andreas.koenig@anima.de (Andreas J. Koenig) writes:
 >> I just discovered that this issue still exists but is not filed as an
 >> issue. Shouldn't it either be fixed or filed?

  > I think so.  Could you file it?

Filed as issue #1038.

-- 
andreas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn diff auth bug

[Karl Fogel <kf...@newton.ch.collab.net>]

andreas.koenig@anima.de (Andreas J. Koenig) writes:
> I just discovered that this issue still exists but is not filed as an
> issue. Shouldn't it either be fixed or filed?

I think so.  Could you file it?

You might mention that in the third case (two URLs), svn should maybe
still see if it can get some auth data from the working directory,
since one often *is* in an appropriate working copy when running this
command, even if the command itself doesn't use the working copy
metadata.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org