[GitHub] [beam] robertwb commented on a change in pull request #11370: Update environments.py to add a method to specify container image

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #11370: Update environments.py to add a method to specify container image
URL: https://github.com/apache/beam/pull/11370#discussion_r406545577
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/environments.py
 ##########
 @@ -252,11 +252,18 @@ def from_runner_api_parameter(payload, capabilities, artifacts, context):
   @classmethod
   def from_options(cls, options):
     # type: (PipelineOptions) -> DockerEnvironment
-    return cls(
+    return from_container_image(
         container_image=options.environment_config,
-        capabilities=python_sdk_capabilities(),
         artifacts=python_sdk_dependencies(options))
 
+  @classmethod
+  def from_container_image(cls, container_image, artifacts=()):
+    # type: (ContainerImage) -> DockerEnvironment
 
 Review comment:
   ```suggestion
       # type: (str) -> DockerEnvironment
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services