You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/07 15:42:48 UTC

[GitHub] [kafka] rhauch opened a new pull request #10833: KAFKA-9374: Corrected the timeout for config validation REST API resource

rhauch opened a new pull request #10833:
URL: https://github.com/apache/kafka/pull/10833


   The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS.
   
   Inspected other uses of the same constant and other changes in the original PR, and found no other errors. This kind of change is actually difficult to test for, so this relies upon existing unit and integration tests.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rhauch commented on pull request #10833: KAFKA-12904: Corrected the timeout for config validation REST API resource

Posted by GitBox <gi...@apache.org>.
rhauch commented on pull request #10833:
URL: https://github.com/apache/kafka/pull/10833#issuecomment-856054711


   Specified the wrong KAFKA issue in my PR branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rhauch closed pull request #10833: KAFKA-12904: Corrected the timeout for config validation REST API resource

Posted by GitBox <gi...@apache.org>.
rhauch closed pull request #10833:
URL: https://github.com/apache/kafka/pull/10833


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org