You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/15 08:48:16 UTC

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #148: [FLINK-27957] Extract AppendOnlyFileStore out of KeyValueFileStore

tsreaper commented on code in PR #148:
URL: https://github.com/apache/flink-table-store/pull/148#discussion_r897709976


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/AppendOnlyFileStoreTable.java:
##########
@@ -62,7 +60,7 @@ public TableScan newScan(boolean incremental) {
         return new TableScan(scan, schema, store.pathFactory()) {
             @Override
             protected void withNonPartitionFilter(Predicate predicate) {
-                scan.withValueFilter(predicate);
+                ((AppendOnlyFileStoreScan) scan).withFilter(predicate);

Review Comment:
   We can't remove this casting even if `AppendOnlyFileStore` returns `AppendOnlyFileStoreScan`. Because in `TableScan` class, `scan` is marked as a `FileTableScan` type. We have to use casting to change it into a subclass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org