You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/06/15 23:54:35 UTC
[Impala-CR](cdh5-trunk) IMPALA-3751: fix clang build errors and warnings
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3391
Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................
IMPALA-3751: fix clang build errors and warnings
Fix misc clang errors and warnings.
Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
---
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/zigzag-test.cc
M be/src/udf/uda-test.cc
3 files changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/91/3391/1
--
To view, visit http://gerrit.cloudera.org:8080/3391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3751: fix clang build errors and warnings
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3751: fix clang build errors and warnings
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................
IMPALA-3751: fix clang build errors and warnings
Fix misc clang errors and warnings.
Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Reviewed-on: http://gerrit.cloudera.org:8080/3391
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/zigzag-test.cc
M be/src/udf/uda-test.cc
3 files changed, 7 insertions(+), 8 deletions(-)
Approvals:
Internal Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/3391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3751: fix clang build errors and warnings
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Internal Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3391
to look at the new patch set (#2).
Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................
IMPALA-3751: fix clang build errors and warnings
Fix misc clang errors and warnings.
Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
---
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/zigzag-test.cc
M be/src/udf/uda-test.cc
3 files changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/91/3391/2
--
To view, visit http://gerrit.cloudera.org:8080/3391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
[Impala-CR](cdh5-trunk) IMPALA-3751: fix clang build errors and warnings
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
GCC warned over the rewrite. Apparently constructing 128-bit integers across compilers isn't that portable. Went with a different approach.
http://gerrit.cloudera.org:8080/#/c/3391/1/be/src/exec/zigzag-test.cc
File be/src/exec/zigzag-test.cc:
PS1, Line 110: ok
> how did this not get caught in GVM?
ZLongResult::error is a valid function pointer, which evaluates to 'true' when implicitly cast to a bool.
--
To view, visit http://gerrit.cloudera.org:8080/3391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3751: fix clang build errors and warnings
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................
Patch Set 1: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/mikeb-gvm/21/
--
To view, visit http://gerrit.cloudera.org:8080/3391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3751: fix clang build errors and warnings
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3391/1/be/src/exec/zigzag-test.cc
File be/src/exec/zigzag-test.cc:
PS1, Line 110: ok
how did this not get caught in GVM?
--
To view, visit http://gerrit.cloudera.org:8080/3391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-HasComments: Yes