[GitHub] [rocketmq] iamqq23ue commented on a change in pull request #3382: FIX ISSUE#2706 the problem of returning SEND_OK after flush failed,The original pull request was #2707.

[GitBox <gi...@apache.org>]

iamqq23ue commented on a change in pull request #3382:
URL: https://github.com/apache/rocketmq/pull/3382#discussion_r724644609



##########
File path: store/src/main/java/org/apache/rocketmq/store/MappedFile.java
##########
@@ -288,6 +289,7 @@ public int flush(final int flushLeastPages) {
                     }
                 } catch (Throwable e) {
                     log.error("Error occurred when force data to disk.", e);
+                    this.flushError = true;

Review comment:
       是的，我认为存储问题发生后一定要保证不可写，否则会导致消息看似写入成功，重启后丢失。而且如果master数据丢失，slave写成功，主备同步也会失败。而且主备同步失败还只会有日志报错，客户端不会有slave_not_available的报错。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org