[jira] [Comment Edited] (BEAM-361) Batch Pub/Sub sink does not set idLabel

["Daniel Halperin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365649#comment-15365649 ] 

Daniel Halperin edited comment on BEAM-361 at 7/7/16 5:47 AM:
--------------------------------------------------------------

This probably requires copying some logic from {{PubsubUnboundedSource}} to {{PubsubReader}}.

Alternately, maybe {{PubsubReader}} should be deleted and {{PubsubUnboundedSource}} used instead using {{BoundedReadFromUnboundedSource}}.

This is a reasonable starter task.


was (Author: dhalperi@google.com):
This probably requires copying some logic from PubsubUnboundedSource to PubsubReader.

Alternately, maybe PubsubReader should be deleted and PubsubUnboundedSource used instead using {{BoundedReadFromUnboundedSource}}.

This is a reasonable starter task.

> Batch Pub/Sub sink does not set idLabel
> ---------------------------------------
>
>                 Key: BEAM-361
>                 URL: https://issues.apache.org/jira/browse/BEAM-361
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Daniel Mills
>              Labels: newbie, starter
>
> The transform should generate a unique token (must be stable across retries), and set it on outgoing pubsub messages if an idLabel has been set



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)