You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Parth Chandra <pc...@maprtech.com> on 2015/04/02 23:21:03 UTC
Re: Review Request 32695: DRILL-2632: Added assertion check to
DRILL-2463 test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32695/#review78729
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On March 31, 2015, 9:31 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32695/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 9:31 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2632
> https://issues.apache.org/jira/browse/DRILL-2632
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> In Drill2463GetNullsFailedWithAssertionsBugTest, added check that Java assertions are enabled, since test depends on their being enabled.
>
>
> Diffs
> -----
>
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2463GetNullsFailedWithAssertionsBugTest.java c8346b1
>
> Diff: https://reviews.apache.org/r/32695/diff/
>
>
> Testing
> -------
>
> Ran with assertions disabled to confirm detection works.
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>