You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2015/08/06 18:01:22 UTC
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/490
Pass the second param to beforeSend
I forgot to send this argument on which broke attachment uploading
COUCHDB-2762
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-fauxton 2762-fix-ajax-csrf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #490
----
commit a6431cc501240c0fd2da1f38677b56356b550b3c
Author: Robert Newson <rn...@apache.org>
Date: 2015-08-06T16:00:25Z
Pass the second param to beforeSend
I forgot to send this argument on which broke attachment uploading
COUCHDB-2762
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/490#issuecomment-128420781
every pr needs a test, i would suggest an integration test to avoid regressions in the future for this feature. example test: https://github.com/apache/couchdb-fauxton/blob/master/app/addons/documents/tests/nightwatch/createsDocument.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/490#issuecomment-128830200
maybe we should avoid merging red builds in the future as a start.
as i said two days ago, i am happy to help next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/490#issuecomment-128834760
it breaks as the tests are not designed for it. you can recreate the issue with
1. creating a database and document in fauxton
2. open http://localhost:8000/_all_docs which proxies to _all_docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/490#issuecomment-128518320
Will you fix the test suite first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/490#issuecomment-128834257
when running the test locally (with `grunt nightwatch --file=createsDatabase`) i get:
```
2015-08-07 23:08:38.335 [warning] node1@127.0.0.1 <0.3783.0> write quorum (2) failed for updated:_dbs
2015-08-07 23:08:38.739 [debug] node1@127.0.0.1 <0.3510.0> httpd 403 error response:
{"error":"forbidden","reason":"CSRF Cookie/Header mismatch"}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/490#issuecomment-128846800
https://github.com/apache/couchdb-fauxton/pull/494
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Pass the second param to beforeSend
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/490#issuecomment-128775600
merged. now let's fix the tests. given the errors are completely opaque, I don't even know where to start.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---