You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Oleg Tkachenko <ol...@multiconn.com> on 2002/12/19 18:11:02 UTC
bidi in the branch
Hello there!
I know, shame on me, shame on me, but I've implemented partial bidi support in
the branch. Sorry, it was urgent commercial requirement.
It seems to be working ok (QA is still verifying it though), but of course
it's a patch actually and I don't like it much. My question is: should I
commit it to the branch codebase? I'm inclining to implement it in a clean way
in the trunk instead of extending/patching the branch.
--
Oleg Tkachenko
eXperanto team
Multiconn Technologies, Israel
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: bidi in the branch
Posted by Oleg Tkachenko <ol...@multiconn.com>.
Jeremias Maerki wrote:
> :-) Ok, you're sentenced to implement the same functionality in the
> trunk.
afaik the trunk is much more suited for bidi, while implementing it for the
branch is really a sentence :)
I'm -0 for the inclusion in the branch as it sends the wrong
> message IMO. But I'm looking forward to seeing bidi support in action in
> the trunk.
I'm still in the middle of the trunk code learning curve, but I think it's not
going to be a problem.
--
Oleg Tkachenko
eXperanto team
Multiconn Technologies, Israel
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: bidi in the branch
Posted by "Peter B. West" <pb...@powerup.com.au>.
Jeremias Maerki wrote:
> Hi Peter
>
> On 20.12.2002 00:30:13 Peter B. West wrote:
>
>>Jeremias Maerki wrote:
>>
>>>:-) Ok, you're sentenced to implement the same functionality in the
>>>trunk. I'm -0 for the inclusion in the branch as it sends the wrong
>>>message IMO. But I'm looking forward to seeing bidi support in action in
>>>the trunk.
>>
>>Jeremias,
>>
>>I would encourage Oleg to bring this functionality into HEAD.
>
>
> Didn't I? :-)
>
Yes; right above. Call my comment an extended +0 for the sentence you
imposed.
>
>>If it
>>already exists in Oleg's working copy of the maint branch (for reasons
>>which have frequently been canvassed here), I think it would be churlish
>>of us to deny access to our faithful band of users.
>
>
> I would agree was it not for something that is an argument for the
> redesign. And read again, please. I wrote -0, not -1. I don't deny
> anything to anybody, just expressing an opinion.
>
Same here - just an opinion. That's why I went for a +0.
>
>>So, fop-0_20_2-maintain +0.
Peter
--
Peter B. West pbwest@powerup.com.au http://www.powerup.com.au/~pbwest/
"Lord, to whom shall we go?"
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: bidi in the branch
Posted by Jeremias Maerki <de...@greenmail.ch>.
Hi Peter
On 20.12.2002 00:30:13 Peter B. West wrote:
> Jeremias Maerki wrote:
> > :-) Ok, you're sentenced to implement the same functionality in the
> > trunk. I'm -0 for the inclusion in the branch as it sends the wrong
> > message IMO. But I'm looking forward to seeing bidi support in action in
> > the trunk.
>
> Jeremias,
>
> I would encourage Oleg to bring this functionality into HEAD.
Didn't I? :-)
> If it
> already exists in Oleg's working copy of the maint branch (for reasons
> which have frequently been canvassed here), I think it would be churlish
> of us to deny access to our faithful band of users.
I would agree was it not for something that is an argument for the
redesign. And read again, please. I wrote -0, not -1. I don't deny
anything to anybody, just expressing an opinion.
> So, fop-0_20_2-maintain +0.
>
> Peter
>
>
> > On 19.12.2002 18:11:02 Oleg Tkachenko wrote:
> >
> >>Hello there!
> >>
> >>I know, shame on me, shame on me, but I've implemented partial bidi support in
> >>the branch. Sorry, it was urgent commercial requirement.
> >>It seems to be working ok (QA is still verifying it though), but of course
> >>it's a patch actually and I don't like it much. My question is: should I
> >>commit it to the branch codebase? I'm inclining to implement it in a clean way
> >>in the trunk instead of extending/patching the branch.
Jeremias Maerki
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: bidi in the branch
Posted by "Peter B. West" <pb...@powerup.com.au>.
Oleg Tkachenko wrote:
> Peter B. West wrote:
>
>> I would encourage Oleg to bring this functionality into HEAD. If it
>> already exists in Oleg's working copy of the maint branch (for reasons
>> which have frequently been canvassed here), I think it would be
>> churlish of us to deny access to our faithful band of users.
>
> May be, but as I said it's neither full nor effective and clean support
> (because I didn't dare to make any significant changes in LineArea
> addText() code etc) and + I exploited Sun proprietary sun.font.Bidi
> class, which is substituted by java.text.Bidi in 1.4. And main concern
> is that we are in the middle of the release candidate testing, so
> introducing any new potentially buggy functionality is not a good idea.
Oleg,
Yes, of course, it would not go in while we have an RC out there. If
you are not happy with the state of the branch code, there's not much
point pursuing it.
Peter
--
Peter B. West pbwest@powerup.com.au http://www.powerup.com.au/~pbwest/
"Lord, to whom shall we go?"
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: bidi in the branch
Posted by Oleg Tkachenko <ol...@multiconn.com>.
Peter B. West wrote:
> I would encourage Oleg to bring this functionality into HEAD. If it
> already exists in Oleg's working copy of the maint branch (for reasons
> which have frequently been canvassed here), I think it would be churlish
> of us to deny access to our faithful band of users.
May be, but as I said it's neither full nor effective and clean support
(because I didn't dare to make any significant changes in LineArea addText()
code etc) and + I exploited Sun proprietary sun.font.Bidi class, which is
substituted by java.text.Bidi in 1.4. And main concern is that we are in the
middle of the release candidate testing, so introducing any new potentially
buggy functionality is not a good idea.
--
Oleg Tkachenko
eXperanto team
Multiconn Technologies, Israel
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: bidi in the branch
Posted by "Peter B. West" <pb...@powerup.com.au>.
Jeremias Maerki wrote:
> :-) Ok, you're sentenced to implement the same functionality in the
> trunk. I'm -0 for the inclusion in the branch as it sends the wrong
> message IMO. But I'm looking forward to seeing bidi support in action in
> the trunk.
Jeremias,
I would encourage Oleg to bring this functionality into HEAD. If it
already exists in Oleg's working copy of the maint branch (for reasons
which have frequently been canvassed here), I think it would be churlish
of us to deny access to our faithful band of users.
So, fop-0_20_2-maintain +0.
Peter
> On 19.12.2002 18:11:02 Oleg Tkachenko wrote:
>
>>Hello there!
>>
>>I know, shame on me, shame on me, but I've implemented partial bidi support in
>>the branch. Sorry, it was urgent commercial requirement.
>>It seems to be working ok (QA is still verifying it though), but of course
>>it's a patch actually and I don't like it much. My question is: should I
>>commit it to the branch codebase? I'm inclining to implement it in a clean way
>>in the trunk instead of extending/patching the branch.
--
Peter B. West pbwest@powerup.com.au http://www.powerup.com.au/~pbwest/
"Lord, to whom shall we go?"
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: bidi in the branch
Posted by Jeremias Maerki <de...@greenmail.ch>.
:-) Ok, you're sentenced to implement the same functionality in the
trunk. I'm -0 for the inclusion in the branch as it sends the wrong
message IMO. But I'm looking forward to seeing bidi support in action in
the trunk.
On 19.12.2002 18:11:02 Oleg Tkachenko wrote:
> Hello there!
>
> I know, shame on me, shame on me, but I've implemented partial bidi support in
> the branch. Sorry, it was urgent commercial requirement.
> It seems to be working ok (QA is still verifying it though), but of course
> it's a patch actually and I don't like it much. My question is: should I
> commit it to the branch codebase? I'm inclining to implement it in a clean way
> in the trunk instead of extending/patching the branch.
Jeremias Maerki
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org