You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2024/01/18 12:55:56 UTC
[PR] [hotfix] Update version to 18.0 [flink-shaded]
snuyanzin opened a new pull request, #133:
URL: https://github.com/apache/flink-shaded/pull/133
Apply update to 18.0 to master branch
cherry-pick of tagged commit https://github.com/apache/flink-shaded/commit/8ac82a30c48dd0221da24599e6b4a3c55583fd62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Update version to 18.0 [flink-shaded]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #133:
URL: https://github.com/apache/flink-shaded/pull/133#issuecomment-1900220507
Actually this is a good point, thanks for raising it
I didn't find this at [1] , so agree we need to update it
I believe @MartijnVisser has more info about that, could you please clarify whether we need to use 19.0 during 19.0 development?
[1] https://cwiki.apache.org/confluence/display/FLINK/Creating+a+flink-shaded+release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Update version to 18.0 [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #133:
URL: https://github.com/apache/flink-shaded/pull/133#discussion_r1458765428
##########
flink-shaded-asm-9/pom.xml:
##########
@@ -25,11 +25,11 @@ under the License.
<parent>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>17.0</version>
+ <version>18.0</version>
Review Comment:
Shouldn't we do an update to 19.0 here (because it's on master)? Similar to how it was done in 725c0caf3abe7982cbcd1f99174aa7d3d881b6b8. I guess, we missed doing it when 17.0 was released. :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Update version to 18.0 [flink-shaded]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #133:
URL: https://github.com/apache/flink-shaded/pull/133#discussion_r1458877150
##########
flink-shaded-asm-9/pom.xml:
##########
@@ -25,11 +25,11 @@ under the License.
<parent>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>17.0</version>
+ <version>18.0</version>
Review Comment:
> I guess, we missed doing it when 17.0 was released. 🤔
I believe we didn't update `flink-shaded` for one of the Flink minor upgrades, because there was (at that moment) no reason to do the update. I don't think that we're following the strict versioning, more an indicator that there's no compatibility guarantees between `flink-shaded` version upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Update version to 18.0 [flink-shaded]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #133:
URL: https://github.com/apache/flink-shaded/pull/133#discussion_r1463042891
##########
flink-shaded-asm-9/pom.xml:
##########
@@ -25,11 +25,11 @@ under the License.
<parent>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>17.0</version>
+ <version>18.0</version>
Review Comment:
Thanks for the response
updated to 19.0
also updated confluence [1] section `Checklist to declare the process completed`
[1] https://cwiki.apache.org/confluence/display/FLINK/Creating+a+flink-shaded+release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Update version to 18.0 [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #133:
URL: https://github.com/apache/flink-shaded/pull/133#discussion_r1459013385
##########
flink-shaded-asm-9/pom.xml:
##########
@@ -25,11 +25,11 @@ under the License.
<parent>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>17.0</version>
+ <version>18.0</version>
Review Comment:
You're right that there is no need to update the version in `master` if there's no change that's applied. But it would be still good to add this as part of the release documentation, wouldn't it? To ensure that we're not forgetting to update the version if a change is applied later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Update version to 18.0 [flink-shaded]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #133:
URL: https://github.com/apache/flink-shaded/pull/133#discussion_r1461508729
##########
flink-shaded-asm-9/pom.xml:
##########
@@ -25,11 +25,11 @@ under the License.
<parent>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded</artifactId>
- <version>17.0</version>
+ <version>18.0</version>
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Update version to 19.0 [flink-shaded]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #133:
URL: https://github.com/apache/flink-shaded/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org