[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #19: [FLINK-30622][Connector/Pulsar] Support consuming messages with schema auto-detection from Pulsar.

["syhily (via GitHub)" <gi...@apache.org>]

syhily commented on code in PR #19:
URL: https://github.com/apache/flink-connector-pulsar/pull/19#discussion_r1100935394


##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StartCursor.java:
##########
@@ -73,18 +73,6 @@ static StartCursor fromMessageId(MessageId messageId, boolean inclusive) {
         return new MessageIdStartCursor(messageId, inclusive);
     }
 
-    /**
-     * This method is designed for seeking message from event time. But Pulsar didn't support
-     * seeking from message time, instead, it would seek the position from publish time. We only
-     * keep this method for backward compatible.
-     *
-     * @deprecated Use {@link #fromPublishTime(long)} instead.
-     */
-    @Deprecated

Review Comment:
   @MartijnVisser Can you post a link here which I can add a Pulsar 4.0.0 release note with all the things we have changed for now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org