You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/06 14:44:39 UTC
[GitHub] [airflow] levahim opened a new pull request #14114: Improved unit tests for open_maybe_zipped function.
levahim opened a new pull request #14114:
URL: https://github.com/apache/airflow/pull/14114
This PR is to address requests formulated in the comments to PR #13984. Namely:
1. As requested by @mik-laj the `airflow.utils.file` unit tests moved out of `test_dag_processing.py` into its own module `test_file.py`.
2. As requested by @ashb the `open_maybe_zipped` function unit test, instead of relying on mocks, now actually reads a test file contents, zipped and plain, and verifies that the returned file content is string in both cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14114:
URL: https://github.com/apache/airflow/pull/14114#issuecomment-774863903
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14114:
URL: https://github.com/apache/airflow/pull/14114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14114:
URL: https://github.com/apache/airflow/pull/14114#issuecomment-774506857
[The Workflow run](https://github.com/apache/airflow/actions/runs/543504592) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] levahim commented on pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
levahim commented on pull request #14114:
URL: https://github.com/apache/airflow/pull/14114#issuecomment-778617716
The CI pipelines cancelled with error: "The self-hosted runner: Airflow Runner 60 lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error." I don't think it's under my control. Can you restart the build? (Or let me know if I can restart it e.g. with special comments.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14114:
URL: https://github.com/apache/airflow/pull/14114#issuecomment-778616457
[The Workflow run](https://github.com/apache/airflow/actions/runs/563715690) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] levahim commented on pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
levahim commented on pull request #14114:
URL: https://github.com/apache/airflow/pull/14114#issuecomment-774506727
The pylint and k8s test errors appear to be completely unrelated to what's in this PR. Seems to be something that came from master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14114:
URL: https://github.com/apache/airflow/pull/14114#issuecomment-774506369
[The Workflow run](https://github.com/apache/airflow/actions/runs/543498130) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14114: Improved unit tests for open_maybe_zipped function.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14114:
URL: https://github.com/apache/airflow/pull/14114#issuecomment-776457476
CI are sad. Can you do a rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org