You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/04 09:19:25 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
HyukjinKwon opened a new pull request #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788
### What changes were proposed in this pull request?
This PR proposes to respect hidden parameters by using `stringArgs` in `Expression.toString `. By this, we can show the strings properly in some cases such as `NonSQLExpression`.
### Why are the changes needed?
To respect "hidden" arguments in the string representation.
### Does this PR introduce any user-facing change?
Yes, for example, on the top of https://github.com/apache/spark/pull/27657,
```scala
val identify = udf((input: Seq[Int]) => input)
spark.range(10).select(identify(array("id"))).show()
```
shows hidden parameter `useStringTypeWhenEmpty`.
```
+---------------------+
|UDF(array(id, false))|
+---------------------+
| [0]|
| [1]|
...
```
whereas:
```scala
spark.range(10).select(array("id")).show()
```
```
+---------+
|array(id)|
+---------+
| [0]|
| [1]|
...
```
### How was this patch tested?
By existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594412300
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24037/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595269597
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119380/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27788: [WIP][SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594582531
**[Test build #119296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119296/testReport)** for PR 27788 at commit [`41085bd`](https://github.com/apache/spark/commit/41085bd371faac0bfaccfd526a83108cbfd9fe46).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594585323
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595434987
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27788: [SPARK-31036][SQL] Use
stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595278315
**[Test build #119400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119400/testReport)** for PR 27788 at commit [`e886efd`](https://github.com/apache/spark/commit/e886efde6f29e4c5f6521179e3456743699f49ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27788: [SPARK-31036][SQL] Use
stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595268589
**[Test build #119380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119380/testReport)** for PR 27788 at commit [`e886efd`](https://github.com/apache/spark/commit/e886efde6f29e4c5f6521179e3456743699f49ef).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#discussion_r388202220
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -533,6 +533,8 @@ case class ArrayExists(
SQLConf.get.getConf(SQLConf.LEGACY_ARRAY_EXISTS_FOLLOWS_THREE_VALUED_LOGIC))
}
+ override def stringArgs: Iterator[Any] = super.stringArgs.take(2)
+
Review comment:
This is actually a followup of https://github.com/apache/spark/pull/27655. I am not going to add a test case because we don't guarantee on the naming against `NonSQLExpression` yet. It is just to make it prettier.
I manually tested as below:
```scala
val identify = udf((input: Boolean) => input)
spark.range(10).select(identify(exists(array(col("id")), _ % 2 === 0))).show()
```
Before:
```
+-------------------------------------------------------------------------------------+
|UDF(exists(array(id), lambdafunction(((lambda 'x % 2) = 0), lambda 'x, false), true))|
+-------------------------------------------------------------------------------------+
| true|
| false|
| true|
...
```
After:
```
+-------------------------------------------------------------------------------+
|UDF(exists(array(id), lambdafunction(((lambda 'x % 2) = 0), lambda 'x, false)))|
+-------------------------------------------------------------------------------+
| true|
| false|
| true|
```
Here, now we hide properly `followThreeValuedLogic` in `ArrayExists`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27788: [SPARK-31036][SQL] Use
stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595276278
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595148325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24117/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595434987
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594412292
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595148325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24117/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595278993
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24137/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595278978
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595148310
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27788: [WIP][SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595147576
**[Test build #119380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119380/testReport)** for PR 27788 at commit [`e886efd`](https://github.com/apache/spark/commit/e886efde6f29e4c5f6521179e3456743699f49ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595269582
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594412300
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24037/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#discussion_r388202220
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -533,6 +533,8 @@ case class ArrayExists(
SQLConf.get.getConf(SQLConf.LEGACY_ARRAY_EXISTS_FOLLOWS_THREE_VALUED_LOGIC))
}
+ override def stringArgs: Iterator[Any] = super.stringArgs.take(2)
+
Review comment:
This is actually a followup of https://github.com/apache/spark/pull/27655. I am not going to add a test case because we don't guarantee on the naming against `NonSQLExpression`. It is just to make it pretty.
I manually tested as below:
```scala
val identify = udf((input: Boolean) => input)
spark.range(10).select(identify(exists(array(col("id")), _ % 2 === 0))).show()
```
Before:
```
+-------------------------------------------------------------------------------------+
|UDF(exists(array(id), lambdafunction(((lambda 'x % 2) = 0), lambda 'x, false), true))|
+-------------------------------------------------------------------------------------+
| true|
| false|
| true|
...
```
After:
```
+-------------------------------------------------------------------------------+
|UDF(exists(array(id), lambdafunction(((lambda 'x % 2) = 0), lambda 'x, false)))|
+-------------------------------------------------------------------------------+
| true|
| false|
| true|
```
Here, now we hide properly `followThreeValuedLogic` in `ArrayExists`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595147576
**[Test build #119380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119380/testReport)** for PR 27788 at commit [`e886efd`](https://github.com/apache/spark/commit/e886efde6f29e4c5f6521179e3456743699f49ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595278993
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24137/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595148310
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595269597
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119380/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595151440
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#discussion_r388202220
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -533,6 +533,8 @@ case class ArrayExists(
SQLConf.get.getConf(SQLConf.LEGACY_ARRAY_EXISTS_FOLLOWS_THREE_VALUED_LOGIC))
}
+ override def stringArgs: Iterator[Any] = super.stringArgs.take(2)
+
Review comment:
This is actually a followup of https://github.com/apache/spark/pull/27655. I am not going to add a test case because we don't guarantee on the naming against `NonSQLExpression` yet. It is just to make it pretty.
I manually tested as below:
```scala
val identify = udf((input: Boolean) => input)
spark.range(10).select(identify(exists(array(col("id")), _ % 2 === 0))).show()
```
Before:
```
+-------------------------------------------------------------------------------------+
|UDF(exists(array(id), lambdafunction(((lambda 'x % 2) = 0), lambda 'x, false), true))|
+-------------------------------------------------------------------------------------+
| true|
| false|
| true|
...
```
After:
```
+-------------------------------------------------------------------------------+
|UDF(exists(array(id), lambdafunction(((lambda 'x % 2) = 0), lambda 'x, false)))|
+-------------------------------------------------------------------------------+
| true|
| false|
| true|
```
Here, now we hide properly `followThreeValuedLogic` in `ArrayExists`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595278315
**[Test build #119400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119400/testReport)** for PR 27788 at commit [`e886efd`](https://github.com/apache/spark/commit/e886efde6f29e4c5f6521179e3456743699f49ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595269582
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594412292
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27788: [WIP][SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594411471
**[Test build #119296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119296/testReport)** for PR 27788 at commit [`41085bd`](https://github.com/apache/spark/commit/41085bd371faac0bfaccfd526a83108cbfd9fe46).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594585342
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119296/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27788: [SPARK-31036][SQL] Use
stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595434179
**[Test build #119400 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119400/testReport)** for PR 27788 at commit [`e886efd`](https://github.com/apache/spark/commit/e886efde6f29e4c5f6521179e3456743699f49ef).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595278978
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594585323
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27788:
[SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden
parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595434992
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119400/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594585342
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119296/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27788: [SPARK-31036][SQL]
Use stringArgs in Expression.toString to respect hidden parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27788: [SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-595434992
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119400/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27788:
[WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect
hidden parameters
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27788: [WIP][SPARK-31036][SQL] Use stringArgs in Expression.toString to respect hidden parameters
URL: https://github.com/apache/spark/pull/27788#issuecomment-594411471
**[Test build #119296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119296/testReport)** for PR 27788 at commit [`41085bd`](https://github.com/apache/spark/commit/41085bd371faac0bfaccfd526a83108cbfd9fe46).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org