You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "vibhatha (via GitHub)" <gi...@apache.org> on 2023/03/09 03:43:33 UTC
[GitHub] [arrow] vibhatha opened a new pull request, #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
vibhatha opened a new pull request, #34508:
URL: https://github.com/apache/arrow/pull/34508
This PR includes a modification to the `ReadRel` in Substrait consumer with Acero. Earlier it was allowed to include the augmented fields, but with this change, the augmented fields are ignored. This only affects when the data source is file/s. The change made in this PR follows the suggestion in the corresponding issue. Test cases were updated to reflect the change and also included a new test case to validate the idea.
This could be a breaking change for some of the existing users who allow augmented fields to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- commented on PR #34508:
URL: https://github.com/apache/arrow/pull/34508#issuecomment-1490665994
Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward ๐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #34508:
URL: https://github.com/apache/arrow/pull/34508#issuecomment-1463927466
> Just a note that I tested this PR against the original issue from the substrait package and it solves things from our end! Thank you!
Thanks for checking this @paleolimbot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- closed pull request #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- closed pull request #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
URL: https://github.com/apache/arrow/pull/34508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34508:
URL: https://github.com/apache/arrow/pull/34508#issuecomment-1461223742
* Closes: #34484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #34508:
URL: https://github.com/apache/arrow/pull/34508#issuecomment-1461322005
@westonpace There are three CIs failing. Not entirely sure why. Looking into it.
Except for that, itโs good for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #34508: GH-34484: [C++] Substrait join results in all zeroes on the righthand side of the join
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #34508:
URL: https://github.com/apache/arrow/pull/34508#issuecomment-1463801170
Just a note that I tested this PR against the original issue from the substrait package and it solves things from our end! Thank you!
<details>
``` r
# remotes::install_github("voltrondata/substrait-r")
library(substrait, warn.conflicts = FALSE)
library(dplyr, warn.conflicts = FALSE)
cities <- tibble::tibble(
city = c("Halifax", "Lancaster", "Chicago"),
country = c("Canada", "United Kingdom", "United States")
)
countries <- tibble::tibble(
country = c("United States", "Canada", "United Kingdom", "Morroco"),
continent = c("North America", "North America", "Europe", "Africa")
)
compiler <- cities |>
arrow_substrait_compiler() |>
substrait_join(countries)
# Bam!
compiler |> collect()
#> # A tibble: 3 ร 4
#> city country.x country.y continent
#> <chr> <chr> <chr> <chr>
#> 1 Halifax Canada Canada North America
#> 2 Lancaster United Kingdom United Kingdom Europe
#> 3 Chicago United States United States North America
```
<sup>Created on 2023-03-10 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org