You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/04 19:43:10 UTC

[GitHub] [skywalking] chenzz opened a new issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

chenzz opened a new issue #8500:
URL: https://github.com/apache/skywalking/issues/8500


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.
   
   
   
   
   
   
   ### Use case
   
   
   
   Image the case:
   > QA send the developer a traceId, and say,
   > "the response of the traceId is not right"
   > The developer get de traceId, but could not find the problem, so he decided to reproduce the problem, and debug the system.
   
   In this case, curl is very useful for developer to reproduce the bug and debug!
   
   <img width="1775" alt="image" src="https://user-images.githubusercontent.com/5676311/152592903-197ca586-ef08-40ee-aa64-ef871557417a.png">
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #8500:
URL: https://github.com/apache/skywalking/issues/8500#issuecomment-1031189659


   UI optimization is fine, but you should notice this of Rockbot UI
   
   > Rocketbot UI is replaced by the new [Booster UI](https://github.com/apache/skywalking-booster-ui) since 9.0.0 release.
   
   So, we are establishing the booster UI in a new repo, https://github.com/apache/skywalking-booster-ui. This is not done yet. I would like to recommend you submitting a pull request after this UI is ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #8500:
URL: https://github.com/apache/skywalking/issues/8500#issuecomment-1031189960


   Closing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #8500:
URL: https://github.com/apache/skywalking/issues/8500#issuecomment-1030414897


   URL, URI and HTTP method, evem with headers are in tags already. Tracing system has to work effectively in high traffic load, this new tag seems not worth.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] chenzz commented on issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

chenzz commented on issue #8500:
URL: https://github.com/apache/skywalking/issues/8500#issuecomment-1031184800


   > URL, URI and HTTP method, evem with headers are in tags already. Tracing system has to work effectively in high traffic load, this new tag seems not worth.
   
   You are right, seems I should change the code of skywalking UI, rather than skywakking agent..
   
   Show the curl command base the old tag, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

wu-sheng closed issue #8500:
URL: https://github.com/apache/skywalking/issues/8500


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #8500:
URL: https://github.com/apache/skywalking/issues/8500#issuecomment-1031199144


   @Fine0830 is the PMC member initializing it. Our plan is around March, 99% of the backend is ready for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] chenzz commented on issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

chenzz commented on issue #8500:
URL: https://github.com/apache/skywalking/issues/8500#issuecomment-1031198088


   Got it.
   
   Do you know, What is the booster UI release plan? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8500: [Feature] Add curl tag on springmvc span, which is useful to reproduce bug and fix bug.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #8500:
URL: https://github.com/apache/skywalking/issues/8500#issuecomment-1030416171


   In some cases, the request could be POST, and the request body would be huge, this tag is very likely causing potential memory issue for few use cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org