You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Stian Soiland-Reyes <st...@apache.org> on 2015/03/02 12:06:09 UTC
Re: incubator-taverna-maven-parent git commit: testing automatic PR
closing - This closes #1
Thanks for testing, Suresh!
I notice both the Author and Committer became Suresh.. should not the
Author field be preserved from GitHub? If it is not easily possible we
should add it manually to the commit messages.
Also https://github.com/apache/incubator-taverna-maven-parent/pull/1
now says "unmerged commits" as the original commits are not merged.
(I have been confused by this before in Jena when Andy has merged or
not merged (I can't easily tell without pulling out git diff) my pull
requests in a similar manner.)
Which commands did you use?
On 2 March 2015 at 00:45, <sm...@apache.org> wrote:
> Repository: incubator-taverna-maven-parent
> Updated Branches:
> refs/heads/master aed938e5e -> 93386b7e6
>
>
> testing automatic PR closing - This closes #1
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/commit/93386b7e
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/tree/93386b7e
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/diff/93386b7e
>
> Branch: refs/heads/master
> Commit: 93386b7e67c9649e065a216ea440aeb706bdb732
> Parents: aed938e
> Author: Suresh Marru <sm...@apache.org>
> Authored: Sun Mar 1 19:45:08 2015 -0500
> Committer: Suresh Marru <sm...@apache.org>
> Committed: Sun Mar 1 19:45:08 2015 -0500
>
> ----------------------------------------------------------------------
> README.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/blob/93386b7e/README.md
> ----------------------------------------------------------------------
> diff --git a/README.md b/README.md
> index a1ea022..c087d56 100644
> --- a/README.md
> +++ b/README.md
> @@ -21,4 +21,4 @@ be done within `<properties>` of each top-level project.
> ## License
>
> Apache Taverna is distributed under the
> -[Apache License, version 2.0](http://www.apache.org/licenses/LICENSE-2.0)
> +[Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0)
>
--
Stian Soiland-Reyes
Apache Taverna (incubating)
http://orcid.org/0000-0001-9842-9718
Re: incubator-taverna-maven-parent git commit: testing automatic PR
closing - This closes #1
Posted by Stian Soiland-Reyes <st...@apache.org>.
OK - see https://github.com/apache/incubator-taverna-maven-parent/pull/2
On 2 March 2015 at 12:46, Suresh Marru <sm...@apache.org> wrote:
>>
>> On Mar 2, 2015, at 6:06 AM, Stian Soiland-Reyes <st...@apache.org> wrote:
>>
>> Thanks for testing, Suresh!
>>
>> I notice both the Author and Committer became Suresh.. should not the
>> Author field be preserved from GitHub? If it is not easily possible we
>> should add it manually to the commit messages.
>
> In this case, I was just testing if the ASF Commits and github PR’s are properly linked up.
>
> Can you create one more PR, let me give a proper try this time to ensure all the issues you highlight below are addressed.
>
> Suresh
>
>>
>> Also https://github.com/apache/incubator-taverna-maven-parent/pull/1
>> now says "unmerged commits" as the original commits are not merged.
>>
>> (I have been confused by this before in Jena when Andy has merged or
>> not merged (I can't easily tell without pulling out git diff) my pull
>> requests in a similar manner.)
>>
>>
>> Which commands did you use?
>>
>> On 2 March 2015 at 00:45, <sm...@apache.org> wrote:
>>> Repository: incubator-taverna-maven-parent
>>> Updated Branches:
>>> refs/heads/master aed938e5e -> 93386b7e6
>>>
>>>
>>> testing automatic PR closing - This closes #1
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/commit/93386b7e
>>> Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/tree/93386b7e
>>> Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/diff/93386b7e
>>>
>>> Branch: refs/heads/master
>>> Commit: 93386b7e67c9649e065a216ea440aeb706bdb732
>>> Parents: aed938e
>>> Author: Suresh Marru <sm...@apache.org>
>>> Authored: Sun Mar 1 19:45:08 2015 -0500
>>> Committer: Suresh Marru <sm...@apache.org>
>>> Committed: Sun Mar 1 19:45:08 2015 -0500
>>>
>>> ----------------------------------------------------------------------
>>> README.md | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/blob/93386b7e/README.md
>>> ----------------------------------------------------------------------
>>> diff --git a/README.md b/README.md
>>> index a1ea022..c087d56 100644
>>> --- a/README.md
>>> +++ b/README.md
>>> @@ -21,4 +21,4 @@ be done within `<properties>` of each top-level project.
>>> ## License
>>>
>>> Apache Taverna is distributed under the
>>> -[Apache License, version 2.0](http://www.apache.org/licenses/LICENSE-2.0)
>>> +[Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0)
>>>
>>
>>
>>
>> --
>> Stian Soiland-Reyes
>> Apache Taverna (incubating)
>> http://orcid.org/0000-0001-9842-9718
>
--
Stian Soiland-Reyes
Apache Taverna (incubating)
http://orcid.org/0000-0001-9842-9718
Re: incubator-taverna-maven-parent git commit: testing automatic PR closing - This closes #1
Posted by Suresh Marru <sm...@apache.org>.
>
> On Mar 2, 2015, at 6:06 AM, Stian Soiland-Reyes <st...@apache.org> wrote:
>
> Thanks for testing, Suresh!
>
> I notice both the Author and Committer became Suresh.. should not the
> Author field be preserved from GitHub? If it is not easily possible we
> should add it manually to the commit messages.
In this case, I was just testing if the ASF Commits and github PR’s are properly linked up.
Can you create one more PR, let me give a proper try this time to ensure all the issues you highlight below are addressed.
Suresh
>
> Also https://github.com/apache/incubator-taverna-maven-parent/pull/1
> now says "unmerged commits" as the original commits are not merged.
>
> (I have been confused by this before in Jena when Andy has merged or
> not merged (I can't easily tell without pulling out git diff) my pull
> requests in a similar manner.)
>
>
> Which commands did you use?
>
> On 2 March 2015 at 00:45, <sm...@apache.org> wrote:
>> Repository: incubator-taverna-maven-parent
>> Updated Branches:
>> refs/heads/master aed938e5e -> 93386b7e6
>>
>>
>> testing automatic PR closing - This closes #1
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/commit/93386b7e
>> Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/tree/93386b7e
>> Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/diff/93386b7e
>>
>> Branch: refs/heads/master
>> Commit: 93386b7e67c9649e065a216ea440aeb706bdb732
>> Parents: aed938e
>> Author: Suresh Marru <sm...@apache.org>
>> Authored: Sun Mar 1 19:45:08 2015 -0500
>> Committer: Suresh Marru <sm...@apache.org>
>> Committed: Sun Mar 1 19:45:08 2015 -0500
>>
>> ----------------------------------------------------------------------
>> README.md | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent/blob/93386b7e/README.md
>> ----------------------------------------------------------------------
>> diff --git a/README.md b/README.md
>> index a1ea022..c087d56 100644
>> --- a/README.md
>> +++ b/README.md
>> @@ -21,4 +21,4 @@ be done within `<properties>` of each top-level project.
>> ## License
>>
>> Apache Taverna is distributed under the
>> -[Apache License, version 2.0](http://www.apache.org/licenses/LICENSE-2.0)
>> +[Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0)
>>
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating)
> http://orcid.org/0000-0001-9842-9718