You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ge...@apache.org on 2021/08/20 12:03:38 UTC

[spark] branch branch-3.2 updated: [SPARK-36551][BUILD] Add sphinx-plotly-directive in Spark release Dockerfile

This is an automated email from the ASF dual-hosted git repository.

gengliang pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.2 by this push:
     new f47a519  [SPARK-36551][BUILD] Add sphinx-plotly-directive in Spark release Dockerfile
f47a519 is described below

commit f47a5197217d4cb1db408e9ffb97f9ff1fdcf27f
Author: Gengliang Wang <ge...@apache.org>
AuthorDate: Fri Aug 20 20:02:24 2021 +0800

    [SPARK-36551][BUILD] Add sphinx-plotly-directive in Spark release Dockerfile
    
    ### What changes were proposed in this pull request?
    
    After https://github.com/apache/spark/pull/32726, Python doc build requires `sphinx-plotly-directive`.
    This PR is to install it from `spark-rm/Dockerfile` to make sure `do-release-docker.sh` can run successfully.
    Also, this PR mentions it in the README of docs.
    
    ### Why are the changes needed?
    
    Fix release script and update README of docs
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    ### How was this patch tested?
    
    Manual test locally.
    
    Closes #33797 from gengliangwang/fixReleaseDocker.
    
    Authored-by: Gengliang Wang <ge...@apache.org>
    Signed-off-by: Gengliang Wang <ge...@apache.org>
    (cherry picked from commit 42eebb84f5b1624d4c0f8dee4fbbdd5e2b02f2a3)
    Signed-off-by: Gengliang Wang <ge...@apache.org>
---
 dev/create-release/spark-rm/Dockerfile | 2 +-
 docs/README.md                         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dev/create-release/spark-rm/Dockerfile b/dev/create-release/spark-rm/Dockerfile
index 20f1dde..ecfb676 100644
--- a/dev/create-release/spark-rm/Dockerfile
+++ b/dev/create-release/spark-rm/Dockerfile
@@ -42,7 +42,7 @@ ARG APT_INSTALL="apt-get install --no-install-recommends -y"
 #   We should use the latest Sphinx version once this is fixed.
 # TODO(SPARK-35375): Jinja2 3.0.0+ causes error when building with Sphinx.
 #   See also https://issues.apache.org/jira/browse/SPARK-35375.
-ARG PIP_PKGS="sphinx==3.0.4 mkdocs==1.1.2 numpy==1.19.4 pydata_sphinx_theme==0.4.1 ipython==7.19.0 nbsphinx==0.8.0 numpydoc==1.1.0 jinja2==2.11.3 twine==3.4.1"
+ARG PIP_PKGS="sphinx==3.0.4 mkdocs==1.1.2 numpy==1.19.4 pydata_sphinx_theme==0.4.1 ipython==7.19.0 nbsphinx==0.8.0 numpydoc==1.1.0 jinja2==2.11.3 twine==3.4.1 sphinx-plotly-directive==0.1.3"
 ARG GEM_PKGS="bundler:2.2.9"
 
 # Install extra needed repos and refresh.
diff --git a/docs/README.md b/docs/README.md
index 4d341f9..d5d04c6 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -73,7 +73,7 @@ See also https://issues.apache.org/jira/browse/SPARK-35375.
 -->
 
 ```sh
-$ sudo pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc 'jinja2<3.0.0'
+$ sudo pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc sphinx-plotly-directive 'jinja2<3.0.0'
 ```
 
 ## Generating the Documentation HTML

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org