[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7669: fix: substrait limit when fetch is None

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7669:
URL: https://github.com/apache/arrow-datafusion/pull/7669#discussion_r1340450490


##########
datafusion/physical-plan/src/limit.rs:
##########
@@ -442,7 +442,7 @@ impl LimitStream {
 
             match &poll {
                 Poll::Ready(Some(Ok(batch))) => {
-                    if batch.num_rows() > 0 && self.skip == 0 {

Review Comment:
   Is the rationale that this condition is redundant because any batch with zero rows will also have self.skip equal to zero?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org