You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/08 05:40:22 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

HyukjinKwon opened a new pull request #28749:
URL: https://github.com/apache/spark/pull/28749


   ### What changes were proposed in this pull request?
   
   This PR proposes to use existing util `org.apache.spark.util.Utils.exceptionString` for the same codes at:
   
   ```
       jwriter = jvm.java.io.StringWriter()
       e.printStackTrace(jvm.java.io.PrintWriter(jwriter))
       stacktrace = jwriter.toString()
   ```
   
   ### Why are the changes needed?
   
   To deduplicate codes. Plus, less communication between JVM and Py4j.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manually tested.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640393130


   There's no test. I just manually tested. I am going to merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640395268






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640381851






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640393241


   Merged to master and branch-3.0.
   
   Thanks, @ueshin.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640383499


   **[Test build #123615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123615/testReport)** for PR 28749 at commit [`87113bc`](https://github.com/apache/spark/commit/87113bc38da7f2d3de8501b8745b6def4f33a6e3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640394926


   **[Test build #123615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123615/testReport)** for PR 28749 at commit [`87113bc`](https://github.com/apache/spark/commit/87113bc38da7f2d3de8501b8745b6def4f33a6e3).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640381524


   @ueshin, can you take a quick look when you're available?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640395268






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640383499


   **[Test build #123615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123615/testReport)** for PR 28749 at commit [`87113bc`](https://github.com/apache/spark/commit/87113bc38da7f2d3de8501b8745b6def4f33a6e3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28749:
URL: https://github.com/apache/spark/pull/28749


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640381851






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28749: [SPARK-31849][PYTHON][SQL][FOLLOW-UP] Deduplicate and reuse Utils.exceptionString in Python exception handling

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28749:
URL: https://github.com/apache/spark/pull/28749#issuecomment-640383499






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org